From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: "Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
<lucas.demarchi@intel.com>, <thomas.hellstrom@linux.intel.com>,
<maarten.lankhorst@linux.intel.com>, <mripard@kernel.org>,
<tzimmermann@suse.de>, <airlied@gmail.com>, <simona@ffwll.ch>,
<intel-xe@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon
Date: Fri, 13 Sep 2024 15:54:37 -0400 [thread overview]
Message-ID: <ZuSYffyZCKW9YJMp@intel.com> (raw)
In-Reply-To: <6bef5f38-5490-4cd0-8e8f-2b2271d20d44@intel.com>
On Fri, Sep 13, 2024 at 11:53:05AM +0530, Ghimiray, Himal Prasad wrote:
>
>
> On 13-09-2024 11:32, Jiapeng Chong wrote:
> > Remove unnecessary semicolon in pick_engine_gt().
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
>
> LGTM
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
pushed to drm-xe-next
Thanks,
Rodrigo.
>
>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> > Changes in v3:
> > -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()".
> >
> > drivers/gpu/drm/xe/xe_irq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> > index 07577b418205..e501002e8a04 100644
> > --- a/drivers/gpu/drm/xe/xe_irq.c
> > +++ b/drivers/gpu/drm/xe/xe_irq.c
> > @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
> > return tile->media_gt;
> > default:
> > break;
> > - };
> > + }
> > fallthrough;
> > default:
> > return tile->primary_gt;
prev parent reply other threads:[~2024-09-13 19:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-13 6:02 [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon Jiapeng Chong
2024-09-13 6:23 ` Ghimiray, Himal Prasad
2024-09-13 19:54 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZuSYffyZCKW9YJMp@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=abaci@linux.alibaba.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=himal.prasad.ghimiray@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=thomas.hellstrom@linux.intel.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox