* [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon
@ 2024-09-13 6:02 Jiapeng Chong
2024-09-13 6:23 ` Ghimiray, Himal Prasad
0 siblings, 1 reply; 3+ messages in thread
From: Jiapeng Chong @ 2024-09-13 6:02 UTC (permalink / raw)
To: lucas.demarchi
Cc: thomas.hellstrom, rodrigo.vivi, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, intel-xe, dri-devel, linux-kernel,
Jiapeng Chong, Abaci Robot
Remove unnecessary semicolon in pick_engine_gt().
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
Changes in v3:
-Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()".
drivers/gpu/drm/xe/xe_irq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
index 07577b418205..e501002e8a04 100644
--- a/drivers/gpu/drm/xe/xe_irq.c
+++ b/drivers/gpu/drm/xe/xe_irq.c
@@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
return tile->media_gt;
default:
break;
- };
+ }
fallthrough;
default:
return tile->primary_gt;
--
2.32.0.3.g01195cf9f
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon
2024-09-13 6:02 [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon Jiapeng Chong
@ 2024-09-13 6:23 ` Ghimiray, Himal Prasad
2024-09-13 19:54 ` Rodrigo Vivi
0 siblings, 1 reply; 3+ messages in thread
From: Ghimiray, Himal Prasad @ 2024-09-13 6:23 UTC (permalink / raw)
To: Jiapeng Chong, lucas.demarchi
Cc: thomas.hellstrom, rodrigo.vivi, maarten.lankhorst, mripard,
tzimmermann, airlied, simona, intel-xe, dri-devel, linux-kernel,
Abaci Robot
On 13-09-2024 11:32, Jiapeng Chong wrote:
> Remove unnecessary semicolon in pick_engine_gt().
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
LGTM
Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> Changes in v3:
> -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()".
>
> drivers/gpu/drm/xe/xe_irq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 07577b418205..e501002e8a04 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
> return tile->media_gt;
> default:
> break;
> - };
> + }
> fallthrough;
> default:
> return tile->primary_gt;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon
2024-09-13 6:23 ` Ghimiray, Himal Prasad
@ 2024-09-13 19:54 ` Rodrigo Vivi
0 siblings, 0 replies; 3+ messages in thread
From: Rodrigo Vivi @ 2024-09-13 19:54 UTC (permalink / raw)
To: Ghimiray, Himal Prasad
Cc: Jiapeng Chong, lucas.demarchi, thomas.hellstrom,
maarten.lankhorst, mripard, tzimmermann, airlied, simona,
intel-xe, dri-devel, linux-kernel, Abaci Robot
On Fri, Sep 13, 2024 at 11:53:05AM +0530, Ghimiray, Himal Prasad wrote:
>
>
> On 13-09-2024 11:32, Jiapeng Chong wrote:
> > Remove unnecessary semicolon in pick_engine_gt().
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
>
> LGTM
> Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
pushed to drm-xe-next
Thanks,
Rodrigo.
>
>
> > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> > ---
> > Changes in v3:
> > -Amend the submission information to "Remove unnecessary semicolon in pick_engine_gt()".
> >
> > drivers/gpu/drm/xe/xe_irq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> > index 07577b418205..e501002e8a04 100644
> > --- a/drivers/gpu/drm/xe/xe_irq.c
> > +++ b/drivers/gpu/drm/xe/xe_irq.c
> > @@ -280,7 +280,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
> > return tile->media_gt;
> > default:
> > break;
> > - };
> > + }
> > fallthrough;
> > default:
> > return tile->primary_gt;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-13 19:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-13 6:02 [PATCH v3 -next] drm/xe/irq: Remove unneeded semicolon Jiapeng Chong
2024-09-13 6:23 ` Ghimiray, Himal Prasad
2024-09-13 19:54 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox