Re: [PATCH v1 4/6] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6

kernel test robot
2024-09-14T13:27:03Z

Hi Parker,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 5ed771f174726ae879945d4f148a9005ac909cb7]

url: https://github.com/intel-lab-lkp/linux/commits/Parker-Newman/misc-eeprom-eeprom_93cx6-Add-quirk-for-extra-read-clock-cycle/20240913-230345
base: 5ed771f174726ae879945d4f148a9005ac909cb7
patch link: https://lore.kernel.org/r/78dead78311ea619e0be99cc32ee0df1610a480d.1726237379.git.pnewman%40connecttech.com
patch subject: [PATCH v1 4/6] serial: 8250_exar: Replace custom EEPROM read with eeprom_93cx6
config: x86_64-randconfig-122-20240914 (https://download.01.org/0day-ci/archive/20240914/202409142138.yCOHBlL1-lkp@intel.com/config)
compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409142138.yCOHBlL1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409142138.yCOHBlL1-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/tty/serial/8250/8250_exar.c:739:13: sparse: sparse: restricted __le32 degrades to integer

vim +739 drivers/tty/serial/8250/8250_exar.c

721
722 /**
723 * cti_read_osc_freq() - Read the UART oscillator frequency from EEPROM
724 * @priv: Device's private structure
725 * @eeprom_offset: Offset where the oscillator frequency is stored
726 *
727 * CTI XR17x15X and XR17V25X cards have the serial boards oscillator frequency
728 * stored in the EEPROM. FPGA and XR17V35X based cards use the PCI/PCIe clock.
729 *
730 * Return: frequency on success, negative error code on failure
731 */
732 static int cti_read_osc_freq(struct exar8250 *priv, u8 eeprom_offset)
733 {
734 __le32 osc_freq_le;
735
736 eeprom_93cx6_multiread(&priv->eeprom, eeprom_offset,
737 (__le16 *)&osc_freq_le, 2);
738
> 739 if (osc_freq_le == 0xFFFFFFFF)
740 return -EIO;
741
742 return le32_to_cpu(osc_freq_le);
743 }
744

--
0-DAY CI Kernel Test Service