Re: [PATCH v1 3/6] misc: eeprom: eeprom_93cx6: Replace printk(KERN_ERR ...) with pr_err()

Greg Kroah-Hartman
2024-09-14T18:58:54Z

On Fri, Sep 13, 2024 at 10:55:40AM -0400, Parker Newman wrote:
> From: Parker Newman <pnewman@connecttech.com>
>
> Replace printk(KERN_ERR ...) with pr_err() to improve readability.
>
> Fixes checkpatch warning:
>
> WARNING: Prefer [subsystem eg: netdev]_err([subsystem]dev, ... then
> dev_err(dev, ... then pr_err(... to printk(KERN_ERR ...
> + printk(KERN_ERR "%s: timeout\n", __func__);
>
> Signed-off-by: Parker Newman <pnewman@connecttech.com>
> ---
> drivers/misc/eeprom/eeprom_93cx6.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/eeprom/eeprom_93cx6.c b/drivers/misc/eeprom/eeprom_93cx6.c
> index 64da22edefa4..755be9a4ffd4 100644
> --- a/drivers/misc/eeprom/eeprom_93cx6.c
> +++ b/drivers/misc/eeprom/eeprom_93cx6.c
> @@ -378,7 +378,7 @@ void eeprom_93cx6_write(struct eeprom_93cx6 *eeprom, u8 addr, u16 data)
> usleep_range(1000, 2000);
>
> if (--timeout <= 0) {
> - printk(KERN_ERR "%s: timeout\n", __func__);
> + pr_err("%s: timeout\n", __func__);

It's a device, please use dev_err().

thanks,

greg k-h