public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Rik van Riel <riel@surriel.com>
Cc: John Ogness <john.ogness@linutronix.de>,
	Andrew Morton <akpm@linux-foundation.org>,
	Omar Sandoval <osandov@meta.com>,
	linux-kernel@vger.kernel.org,
	Steven Rostedt <rostedt@goodmis.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>,
	kernel-team <kernel-team@meta.com>
Subject: Re: [RFC PATCH] nmi,printk: fix ABBA deadlock between nmi_backtrace and dump_stack_lvl
Date: Mon, 16 Sep 2024 16:33:46 +0200	[thread overview]
Message-ID: <ZuhBymvNiB_8sWMu@pathway.suse.cz> (raw)
In-Reply-To: <dbed42dc3bc05fa772e11b54e93526a66698401f.camel@surriel.com>

On Fri 2024-09-13 13:25:33, Rik van Riel wrote:
> On Wed, 2024-07-24 at 17:08 +0200, Petr Mladek wrote:
> > On Wed 2024-07-24 16:51:46, John Ogness wrote:
> > 
> > 
> > I see. I agree that deferring printk on that CPU [0] is the right
> > solution.
> > 
> > > [0]
> > > https://lore.kernel.org/lkml/87plrcqyii.fsf@jogness.linutronix.de
> > 
> Hi Petr,
> 
> we have been running with John Ogness's fix (from the mail linked
> above) for about a month now, and it has reduced the number of
> deadlocks in the Linux kernel in our fleet by maybe 90%, comparing
> a kernel with the fix, to a kernel without the fix.
> 
> Would it be possible to get John Ogness's fix queued up for merging
> in the printk tree, and then later to Linus?

Sure. Thanks for reminder.

John, could you please send the fix as a proper patch with some
reasonable commit message?

Best Regards,
Petr

  reply	other threads:[~2024-09-16 14:33 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-16  3:20 [RFC PATCH] nmi,printk: fix ABBA deadlock between nmi_backtrace and dump_stack_lvl Rik van Riel
2024-07-17  7:16 ` John Ogness
2024-07-17 13:47   ` Rik van Riel
2024-07-18  7:25     ` John Ogness
2024-07-18 13:38       ` Rik van Riel
2024-07-18 14:09         ` John Ogness
2024-07-18 15:23           ` Rik van Riel
2024-07-24 12:56           ` Petr Mladek
2024-07-24 14:45             ` John Ogness
2024-07-24 15:08               ` Petr Mladek
2024-09-13 17:25                 ` Rik van Riel
2024-09-16 14:33                   ` Petr Mladek [this message]
2024-07-24 16:55             ` Rik van Riel
2024-07-24 12:45   ` Petr Mladek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuhBymvNiB_8sWMu@pathway.suse.cz \
    --to=pmladek@suse.com \
    --cc=akpm@linux-foundation.org \
    --cc=john.ogness@linutronix.de \
    --cc=kernel-team@meta.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=osandov@meta.com \
    --cc=riel@surriel.com \
    --cc=rostedt@goodmis.org \
    --cc=senozhatsky@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox