From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: "Chen-Yu Tsai" <wens@csie.org>,
"Jernej Skrabec" <jernej.skrabec@gmail.com>,
"Samuel Holland" <samuel@sholland.org>,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ondřej Jirman" <megi@xff.cz>
Subject: Re: [PATCH] arm64: dts: sun50i-a64-pinephone: Add mount matrix for accelerometer
Date: Tue, 17 Sep 2024 20:56:26 +0300 [thread overview]
Message-ID: <ZunCysUTSfQU1ylg@skv.local> (raw)
In-Reply-To: <6e5d0e9978bff30559c17f30d1495b59@manjaro.org>
Hi, Dragan,
On 24-09-16 23:08, Dragan Simic wrote:
> Hello Andrey,
>
> On 2024-09-16 22:45, Andrey Skvortsov wrote:
> > From: Ondřej Jirman <megi@xff.cz>
> >
> > accelerometer is mounted the way x and z-axis are invereted, x and y
> > axis have to be spawed to match device orientation.
> > The mount matrix is based on PCB drawing and was tested on the device.
>
> This commit summary should be copyedited for grammar and style. If
> you want, I can provide a copyedited version?
It would be helpful to avoid further grammar/style problems in the
commit message. Thanks in advance.
>
> > Signed-off-by: Ondrej Jirman <megi@xff.cz>
> > Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> > ---
> > arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > index bc6af17e9267a..1da7506c38cd0 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
> > @@ -229,6 +229,9 @@ accelerometer@68 {
> > interrupts = <7 5 IRQ_TYPE_EDGE_RISING>; /* PH5 */
> > vdd-supply = <®_dldo1>;
> > vddio-supply = <®_dldo1>;
> > + mount-matrix = "0", "1", "0",
> > + "-1", "0", "0",
> > + "0", "0", "-1";
> > };
> > };
--
Best regards,
Andrey Skvortsov
next prev parent reply other threads:[~2024-09-17 17:56 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 20:45 [PATCH] arm64: dts: sun50i-a64-pinephone: Add mount matrix for accelerometer Andrey Skvortsov
2024-09-16 21:08 ` Dragan Simic
2024-09-17 17:56 ` Andrey Skvortsov [this message]
2024-09-18 9:27 ` Dragan Simic
2024-09-18 10:02 ` Dragan Simic
2024-09-18 11:00 ` Andrey Skvortsov
2024-09-18 11:22 ` Dragan Simic
2024-09-18 11:27 ` Dragan Simic
2024-09-18 13:41 ` Andrey Skvortsov
2024-09-18 15:58 ` Andrey Skvortsov
2024-09-19 18:34 ` Dragan Simic
2024-09-21 7:44 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZunCysUTSfQU1ylg@skv.local \
--to=andrej.skvortzov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dsimic@manjaro.org \
--cc=jernej.skrabec@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=megi@xff.cz \
--cc=robh@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox