From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43FE31A00D6 for ; Thu, 19 Sep 2024 17:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726768486; cv=none; b=PRfngHE47FGaHhY60h4ac8mMan8laWmW6maUCpmQ/tOCUHPz1RK/a50N8jH1HE5OxO/pI6iLx4J6J+pTJCF6VQFaKBgtsF4X1U4CwRuc0GuGU1eBmPFYgI5ZBT4kyx05piSdWE2LM7wdEw/OrUjzgQthD+rrfdOqIwsh9ss2rik= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1726768486; c=relaxed/simple; bh=L2EgTXNrTRq/ZjjH1kSInpyVrSWJD/vH4Z+1Xj/9HIs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pwdPKo8IAAIlA7MSOK9e8yM3VvBCrPpUSbJhqo6vyJ+qVXOHmRSlntORYXdTMmvGnFWSkEmjh9fJHBmEmVrXCth+cQIANyxz99twz3gfptsVmWiiEl4WQJ2qzuilura65SAQV55iFBW9tqEzAvvK/bWflsfw6+RexJ7oK77TYJ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=DIcLuD2A; arc=none smtp.client-ip=209.85.216.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="DIcLuD2A" Received: by mail-pj1-f45.google.com with SMTP id 98e67ed59e1d1-2d87f34a650so858842a91.1 for ; Thu, 19 Sep 2024 10:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1726768483; x=1727373283; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=S5Z/MiCwV25IPgl2HkDVjcuqIYV04L7ZzrLDbbmmiKY=; b=DIcLuD2AzHj8GBQdESnaiC2ebjVUFxkd/W/J42HjviX7J2FGDci//Halw8ZxAv4WAE zi87JnXBjMd6HO1ZJzr5o1u/HbJFGSABY3MtBlkwPuuuz9Tj6OFFYWeXH0nouoWVkcJy BfBYMPz/DycDlfdVIU8d3U0fgDTdJMYumEzXvs7+RHAKLF7dC8jQ3F980lIApMJUx4bP cqV4feCFzIbTc62t+M82dJmwbfM3GNSkjwZLx+oCTP7uT2KzzTtSXU0ReIzJDX5In1s4 XHOrSA2YcRISgt1FLHMSM/HR+oJRPObpVlrU+G+lHr6hyH88YNRX2FIwZZA9UUsH17r+ fxqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726768483; x=1727373283; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S5Z/MiCwV25IPgl2HkDVjcuqIYV04L7ZzrLDbbmmiKY=; b=vSTszwDVx766omm+hZIDf/QquVbnObWu6SFbxXBjdo+m4i3Cc9pQKrSUhAyD2nTU+H DiwDj9T47q5zQjxx9733JxfP4eUH5vX7kEQLhJ/6NCjS4EI62oRTLLsTNga+9oBUzaxL la8l+388zr38zVBmmxok6bN4Oz5Een/tfDQM2bTGP8PYP0sMywrdt+DFRCtvYVJMst5f 8tkDWehXFGT42q1YrtHdyvZ6+Pd10OGungRsY0dhYhkshITm8geV6Do1KEtHgo7gDh0X /2sMix/7nzJACRvngkperuEld7rRXi63/CcerQGBzHRQAAfA3GQ5G/GXQ/kHhMKs8pSR SpTA== X-Forwarded-Encrypted: i=1; AJvYcCXGbFblhzt6HC+0v582MaQ3ecC9jZYxK1sQU0zqXLxnPsjfAxOhDiAP8pPtEH7/UvIRYtyN2oqdAKK5bXQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzLU/FAhSrquqcDAsecKas05Eqo+yt4cz3bt9MyPrtZZ34t3CCU yyAIZimiAvv8t8ZEv9waOAM+eFdr5vkhrhx3CIbvsgUtz0ln7Fr70uZj/z5tluA= X-Google-Smtp-Source: AGHT+IHxbXl5qPD2Oz6Nk3e5ksHxOGqb+RhkZlOpyrQZFj/u1RlaBeB0FXDYtRQehBRwsqQi32jufg== X-Received: by 2002:a17:90b:b09:b0:2da:50e6:5ab with SMTP id 98e67ed59e1d1-2dd6cecb68fmr6147970a91.18.1726768483450; Thu, 19 Sep 2024 10:54:43 -0700 (PDT) Received: from medusa.lab.kspace.sh ([208.88.152.253]) by smtp.googlemail.com with ESMTPSA id 98e67ed59e1d1-2dd6ee9f43dsm2248810a91.24.2024.09.19.10.54.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Sep 2024 10:54:43 -0700 (PDT) Date: Thu, 19 Sep 2024 10:54:41 -0700 From: Mohamed Khalfella To: Moshe Shemesh Cc: Przemek Kitszel , yzhong@purestorage.com, Shay Drori , Saeed Mahameed , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, Leon Romanovsky , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Tariq Toukan Subject: Re: [PATCH v2 0/1] net/mlx5: Added cond_resched() to crdump collection Message-ID: References: <20240829213856.77619-1-mkhalfella@purestorage.com> <43e7d936-f3c6-425a-b2ff-487c88905a0f@intel.com> <36b5d976-1fcb-45b9-97dd-19f048997588@nvidia.com> <3d1be80f-4195-4b44-807e-92aa674307b7@nvidia.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3d1be80f-4195-4b44-807e-92aa674307b7@nvidia.com> On 2024-09-19 20:40:48 +0300, Moshe Shemesh wrote: > > > On 9/19/2024 8:24 PM, Mohamed Khalfella wrote: > > > > On 2024-09-04 20:38:13 -0700, Mohamed Khalfella wrote: > >> On 2024-08-30 12:51:43 +0300, Moshe Shemesh wrote: > >>> > >>> > >>> On 8/30/2024 10:08 AM, Przemek Kitszel wrote: > >>> > >>>> > >>>> On 8/30/24 01:58, Mohamed Khalfella wrote: > >>>>> On 2024-08-29 15:38:55 -0600, Mohamed Khalfella wrote: > >>>>>> Changes in v2: > >>>>>> - Removed cond_resched() in mlx5_vsc_wait_on_flag(). The idea is that > >>>>>> usleep_range() should be enough. > >>>>>> - Updated cond_resched() in mlx5_vsc_gw_read_block_fast every 128 > >>>>>> iterations. > >>>>>> > >>>>>> v1: > >>>>>> https://lore.kernel.org/all/20240819214259.38259-1-mkhalfella@purestorage.com/ > >>>>>> > >>>>>> Mohamed Khalfella (1): > >>>>>> net/mlx5: Added cond_resched() to crdump collection > >>>>>> > >>>>>> drivers/net/ethernet/mellanox/mlx5/core/lib/pci_vsc.c | 4 ++++ > >>>>>> 1 file changed, 4 insertions(+) > >>>>>> > >>>>>> -- > >>>>>> 2.45.2 > >>>>>> > >>>>> > >>>>> Some how I missed to add reviewers were on v1 of this patch. > >>>>> > >>>> > >>>> You did it right, there is need to provide explicit tag, just engaging > >>>> in the discussion is not enough. v2 is fine, so: > >>>> Reviewed-by: Przemek Kitszel > >>> > >>> Reviewed-by: Moshe Shemesh > >>> And fixes tag should be: > >>> Fixes: 8b9d8baae1de ("net/mlx5: Add Crdump support") > >> > >> Will add the tag in v3. > > > > A quick follow up on this patch. I posted v3 [1] of this patch with > > minor changes. There are no functional differences between v2 and v3 of > > this patch. The commit messsage on v3 has information why call > > cond_resched() every 128 iterations, so that could be useful to add. > > > > Is there anything I need to do to get v2 or v3 of this patch merged? > > I already added my reviewed-by tag on this patch you can see up here, > same goes to v3. > Thanks. Thank you.