From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Okan Tumuklu <okantumukluu@gmail.com>, shuah@kernel.org
Cc: linux-kernel@vger.kernel.org,
"Okan Tümüklü" <117488504+Okan-tumuklu@users.noreply.github.com>
Subject: Re: [PATCH] Update core.c
Date: Wed, 2 Oct 2024 21:11:21 +0700 [thread overview]
Message-ID: <Zv1UiXMbwlK9mieQ@archie.me> (raw)
In-Reply-To: <20240930220649.6954-1-okantumukluu@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 634 bytes --]
On Tue, Oct 01, 2024 at 01:06:49AM +0300, Okan Tumuklu wrote:
> From: Okan Tümüklü <117488504+Okan-tumuklu@users.noreply.github.com>
Please use your real email address and don't forget to add Signed-off-by:
trailer (`git commit -s` does it for you).
>
> 1:The control flow was simplified by using else if statements instead of goto structure.
>
> 2:Error conditions are handled more clearly.
>
> 3:The device_unlock call at the end of the function is guaranteed in all cases.
Split logical changes into separate patches - in a patch set.
Thanks.
--
An old man doll... just what I always wanted! - Clara
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-10-02 14:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 22:06 [PATCH] Update core.c Okan Tumuklu
2024-09-30 22:12 ` Shuah Khan
2024-09-30 22:20 ` Conor Dooley
2024-10-02 13:27 ` Jakub Kicinski
2024-10-02 15:26 ` Shuah Khan
2024-10-02 22:21 ` Al Viro
2024-10-02 23:41 ` Jakub Kicinski
2024-10-02 14:11 ` Bagas Sanjaya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1UiXMbwlK9mieQ@archie.me \
--to=bagasdotme@gmail.com \
--cc=117488504+Okan-tumuklu@users.noreply.github.com \
--cc=linux-kernel@vger.kernel.org \
--cc=okantumukluu@gmail.com \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox