From: Andy Shevchenko <andy@kernel.org>
To: linux@treblig.org
Cc: kees@kernel.org, akpm@linux-foundation.org, pmladek@suse.com,
rostedt@goodmis.org, linux@rasmusvillemoes.dk,
senozhatsky@chromium.org, linux-hardening@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printf: Remove unused 'bprintf'
Date: Wed, 2 Oct 2024 17:11:31 +0300 [thread overview]
Message-ID: <Zv1Uk_3W2hu1M8-9@smile.fi.intel.com> (raw)
In-Reply-To: <20241002012125.405368-1-linux@treblig.org>
On Wed, Oct 02, 2024 at 02:21:25AM +0100, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> bprintf is unused. Remove it.
bprintf()
> It was added in
> commit 4370aa4aa753 ("vsprintf: add binary printf")
>
> but as far as I can see was never used, unlike the other
> two functions in that patch.
Please, rewrap these lines to use more room on each line.
...
I am not familiar with tricks in BPF or ftrace code where this actually might
be implicitly called via a macro, but brief grep gives nothing that might point
to that. Hence, with the amended commit message
Reviewed-by: Andy Shevchenko <andy@kernel.org>
P.S. I hope we may rely in CIs to report issues soon, if any.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-02 14:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-02 1:21 [PATCH] printf: Remove unused 'bprintf' linux
2024-10-02 14:11 ` Andy Shevchenko [this message]
2024-10-02 14:31 ` Dr. David Alan Gilbert
2024-10-02 14:45 ` Andy Shevchenko
2024-10-02 14:52 ` Dr. David Alan Gilbert
2024-10-02 14:48 ` Steven Rostedt
2024-10-02 17:32 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv1Uk_3W2hu1M8-9@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=linux@treblig.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox