Re: [PATCH v2] printk: Improve memory usage logging during boot

[Isaac Manjarres <isaacmanjarres@google.com>]

On Tue, Oct 01, 2024 at 05:46:31PM +0200, Petr Mladek wrote:
> On Mon 2024-09-30 11:48:24, Isaac J. Manjarres wrote:
> > With the new logs, it is much easier to see exactly why the memory
> > increased by 2304 KB:
> > 
> > log_buf_len=512K:
> > 
> > printk: log_buf_len: 524288 bytes
> > printk: prb_descs size: 393216 bytes
> > printk: printk_infos size: 1441792 bytes
> 
> This should get updated to the new format.
> If I count correctly then it should be:
> 
> printk: log buffer data + meta data: 524288 + 1835008 = 2359296 bytes
Sorry, I forgot to do that; thanks for catching it. Yes, the
calculation is correct.

> > Memory: ... (... 733252K reserved ...)
> > 
> > log_buf_len=1M:
> > 
> > printk: log_buf_len: 1048576 bytes
> > printk: prb_descs size: 786432 bytes
> > printk: printk_infos size: 2883584 bytes
> 
> and here:
> 
> printk: log buffer data + meta data: 1048576 + 3670016 = 4718592 bytes
This is also correct.

> > Memory: ... (... 735556K reserved ...)
> >
> > Signed-off-by: Isaac J. Manjarres <isaacmanjarres@google.com>
> 
> Otherwise, it looks good. With the updated commit message:
> 
> Reviewed-by: Petr Mladek <pmladek@suse.com>
> Tested-by: Petr Mladek <pmladek@suse.com>
> 
> 
> Note need to send v3. I could update the commit message when committing
> the patch.
> 
> I am going to wait few days for a potential another review
> before pushing.
Thank you Petr for your review and for picking this up! I really
appreciate it.

Thanks,
Isaac