Re: [PATCH v14 0/3] Add ASPEED AST2600 I2Cv2 controller driver

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Thu, Oct 03, 2024 at 02:20:54PM +0200, Andi Shyti wrote:
> On Thu, Oct 03, 2024 at 01:15:50PM GMT, Andy Shevchenko wrote:
> > On Thu, Oct 03, 2024 at 03:41:57AM +0000, Ryan Chen wrote:
> > > > On Wed, Oct 02, 2024 at 03:02:10PM +0800, Ryan Chen wrote:

...

> > > > Is it possible to switch to new terminology wherever it's possible?
> > > > I.e. master --> controller, slave --> target. See, for example, f872d28500bd
> > > > ("i2c: uniphier-f: reword according to newest specification").
> > > > 
> > > Just for cover latter? Or I should modify for each patches commit message?
> > > Or entire i2c driver statement need switch to target?
> > 
> > I believe everywhere, where it applies: driver code, comments, documentation,
> > commit messages...
> 
> If the datasheet refers to a register, state, or any other
> hardware property as master/slave, we should retain the
> master/slave terminology. Otherwise, we should follow the i2c and
> smbus specifications and use controller/target.

Indeed, makes sense. Thank you, Andi, for the corrections!

-- 
With Best Regards,
Andy Shevchenko