From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA762772A for ; Sun, 22 Sep 2024 21:21:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727040063; cv=none; b=A5/FSMhw4iNaUrrvIN0MgC1Y5MMVCf5p6tEASqluC3GnqwpJ4Mf3sBJNhoY9DAZW6HRwwrN5lY1PfBs1i/RHEU9SS2MYbWz4Cv8ijGPtfbkHSK1vBQWpDzTtGRuxDk9ZaXtg17a+x9twSuLoNpfx+lfYUiVp1R/Dh8k+SZAyGuo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727040063; c=relaxed/simple; bh=xXvT2xbLlx/19IWOYFaETJQvkB6DsO1He9ca8kF21LA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kB4HqRNnPkw3S4fRU3v5NmzB1l5cEoXelXmOejss7IbjTcG0dKQNngVnbC+CQAcKvilnDDS7sXJlAs+4vHwGQWEnP79tPlwBpcIWTJgQ18M7DNQYXVxNRuXdwD8lOp1VnYrdpnqxlAclXt48yS0UGJBAk6q3kT7iz16lipoUbU0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=khjSdLE2; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="khjSdLE2" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2634CC4CEC3; Sun, 22 Sep 2024 21:21:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1727040063; bh=xXvT2xbLlx/19IWOYFaETJQvkB6DsO1He9ca8kF21LA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=khjSdLE2QLp41n3O1zXwE3MSH6TKUGG+IEAq0mfaH4J32pw3mL8HEMDLVtm1esOOW yMu1ijYYqQmAKsdLHE25mdyMJ+AUXbqnSLzo42jcMRsAuVaAYGU9R61FVSJtzhHDk0 if2Bfc6DBP1jcBxGKiWCLoC3PNEtmohWT6euAuuJkgvpveEQ/5bIwxjNGS8B/vfBUz HMJy/sDBhUUwyb0jKL2OMmcHatNXRlhg2HHyFGrVLNq5dEic76L8BoQHil4sx5TI7m 2ZND67cw+O6GltZl0oPKghKKZAUHJ5w5Qm9d+A7BmlQ6/kEencuhyAeYSuSrfEPsBZ Fgo6u34OJ1alg== Date: Sun, 22 Sep 2024 11:21:02 -1000 From: Tejun Heo To: andrea.righi@linux.dev Cc: David Vernet , Giovanni Gherdovich , Kleber Sacilotto de Souza , Marcelo Henrique Cerri , Phil Auld , linux-kernel@vger.kernel.org Subject: Re: [PATCH] sched_ext: Provide a sysfs enable_seq counter Message-ID: References: <20240921193921.75594-1-andrea.righi@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240921193921.75594-1-andrea.righi@linux.dev> Hello, Andrea. On Sat, Sep 21, 2024 at 09:39:21PM +0200, andrea.righi@linux.dev wrote: > static struct attribute *scx_global_attrs[] = { > &scx_attr_state.attr, > &scx_attr_switch_all.attr, > &scx_attr_nr_rejected.attr, > &scx_attr_hotplug_seq.attr, > + &scx_attr_enable_seq.attr, > NULL, > }; Can you put this in scx_sched_attrs instead as it probably would make sense to track this per-scheduler in the future when we support stacked schedulers. Thanks. -- tejun