From: Andy Shevchenko <andy@kernel.org>
To: Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Nuno Sa" <nuno.sa@analog.com>,
"Olivier Moysan" <olivier.moysan@foss.st.com>,
"Uwe Kleine-König" <ukleinek@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
"João Paulo Gonçalves" <joao.goncalves@toradex.com>,
"Dumitru Ceclan" <mitrutzceclan@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Alisa-Dariana Roman" <alisadariana@gmail.com>,
"Marius Cristea" <marius.cristea@microchip.com>,
"Sergiu Cuciurean" <sergiu.cuciurean@analog.com>,
"Dragos Bogdan" <dragos.bogdan@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 2/7] iio: backend: add support for data size set
Date: Mon, 23 Sep 2024 14:17:59 +0300 [thread overview]
Message-ID: <ZvFOZxZXzY18qljX@smile.fi.intel.com> (raw)
In-Reply-To: <20240923101206.3753-3-antoniu.miclaus@analog.com>
On Mon, Sep 23, 2024 at 01:10:19PM +0300, Antoniu Miclaus wrote:
> Add backend support for setting the data size used.
...
> + * RETURNS:
It's main in this file, please add a patch that converts all 'RETURN' and
'RETURNS' to 'Return:'. Or at bare minimum use "Return:" here.
> + */
...
> + if (!size)
> + return -EINVAL;
Why 0 can be set? Is it default?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-23 11:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-23 10:10 [PATCH 0/7] *** Add support for AD485x DAS Family *** Antoniu Miclaus
2024-09-23 10:10 ` [PATCH 1/7] iio: backend: add API for interface get Antoniu Miclaus
2024-09-26 8:40 ` David Lechner
2024-09-26 10:52 ` Nuno Sá
2024-09-28 17:23 ` Jonathan Cameron
2024-09-30 6:46 ` Nuno Sá
2024-09-23 10:10 ` [PATCH 2/7] iio: backend: add support for data size set Antoniu Miclaus
2024-09-23 11:17 ` Andy Shevchenko [this message]
2024-09-26 9:10 ` David Lechner
2024-09-28 17:24 ` Jonathan Cameron
2024-09-23 10:10 ` [PATCH 3/7] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-09-23 10:10 ` [PATCH 4/7] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-09-26 9:08 ` David Lechner
2024-09-23 10:10 ` [PATCH 5/7] dt-bindings: iio: adc: add ad458x Antoniu Miclaus
2024-09-23 21:20 ` Conor Dooley
2024-09-24 13:42 ` David Lechner
2024-09-24 22:32 ` Rob Herring
2024-09-23 10:10 ` [PATCH 6/7] iio: adc: ad485x: add ad485x driver Antoniu Miclaus
2024-09-23 11:43 ` Andy Shevchenko
2024-09-24 16:08 ` kernel test robot
2024-09-26 14:39 ` David Lechner
2024-09-26 15:00 ` Andy Shevchenko
2024-09-28 17:30 ` Jonathan Cameron
2024-09-29 19:21 ` Andy Shevchenko
2024-09-30 7:05 ` Nuno Sá
2024-10-05 17:26 ` Jonathan Cameron
2024-10-11 10:23 ` Nuno Sá
2024-10-12 10:31 ` Jonathan Cameron
2024-09-28 17:47 ` Jonathan Cameron
2024-10-01 11:53 ` Miclaus, Antoniu
2024-10-01 12:54 ` Andy Shevchenko
2024-10-01 13:51 ` Miclaus, Antoniu
2024-10-01 14:08 ` David Lechner
2024-10-03 10:14 ` Miclaus, Antoniu
2024-10-03 10:35 ` Andy Shevchenko
2024-10-03 13:08 ` David Lechner
2024-10-04 14:07 ` Miclaus, Antoniu
2024-10-05 17:27 ` Jonathan Cameron
2024-09-23 10:10 ` [PATCH 7/7] Documentation: ABI: testing: ad485x: add ABI docs Antoniu Miclaus
2024-09-23 11:45 ` Andy Shevchenko
2024-09-28 17:32 ` Jonathan Cameron
2024-09-23 11:14 ` [PATCH 0/7] *** Add support for AD485x DAS Family *** Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvFOZxZXzY18qljX@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=alisadariana@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=joao.goncalves@toradex.com \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=marcelo.schmitt@analog.com \
--cc=marius.cristea@microchip.com \
--cc=mitrutzceclan@gmail.com \
--cc=nuno.sa@analog.com \
--cc=olivier.moysan@foss.st.com \
--cc=robh@kernel.org \
--cc=sergiu.cuciurean@analog.com \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox