From: "John B. Wyatt IV" <jwyatt@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Guenter Roeck <linux@roeck-us.net>,
Shuah Khan <skhan@linuxfoundation.org>,
linux-pm@vger.kernel.org, Thomas Renninger <trenn@suse.com>,
Shuah Khan <shuah@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-kernel@vger.kernel.org, John Kacur <jkacur@redhat.com>,
Tomas Glozar <tglozar@redhat.com>, Arnaldo Melo <acme@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"John B. Wyatt IV" <sageofredondo@gmail.com>
Subject: Re: [PATCH v3 2/4] pm:cpupower: Add SWIG bindings files for libcpupower
Date: Mon, 23 Sep 2024 09:29:00 -0400 [thread overview]
Message-ID: <ZvFtHM5465aOYX24@rhfedora> (raw)
In-Reply-To: <CAHk-=wjVpftmPF3SopywFgQ+uzgdScTPWTxmq7HwinVqwbue3w@mail.gmail.com>
On Sun, Sep 22, 2024 at 08:39:28AM -0700, Linus Torvalds wrote:
> On Sat, 21 Sept 2024 at 14:23, Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On Wed, Sep 04, 2024 at 10:19:09PM -0400, John B. Wyatt IV wrote:
> > >
> > > .../bindings/python/raw_pylibcpupower.i | 247 ++++++++++++++++++
> >
> > This file is deleted when running "make mrproper".
>
> Yes, please don't create files called '*.i", "*.s" or "*.o". We
> assume they are generated files (the result of the preprocessor, the
> compiler, and the assembler respectively).
>
> And yeah, obviously "*.i" and "*.s" and not _usually_ seen, because
> they are only steps on the way to "*.o", so maybe they aren't _quite_
> as obvious as some "*.o" file would be, but they are very much
> standard naming, and we have build rules for them (ie "make
> kernel/exit.i" will create the pre-processed result of exit.c).
>
My apologies. This was reported and fixed with this patch by renaming
the file to '.swg'. '.swg' is the second filename extension used by
SWIG.
https://lore.kernel.org/linux-pm/20240913201705.7764-1-minhuadotchen@gmail.com/
--
Sincerely,
John Wyatt
Software Engineer, Core Kernel
Red Hat
next prev parent reply other threads:[~2024-09-23 13:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 2:19 [PATCH v3 0/4] Add SWIG Bindings to libcpupower John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 1/4] pm:cpupower: Add missing powercap_set_enabled() stub function John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 2/4] pm:cpupower: Add SWIG bindings files for libcpupower John B. Wyatt IV
2024-09-21 21:23 ` Guenter Roeck
2024-09-22 15:39 ` Linus Torvalds
2024-09-23 13:29 ` John B. Wyatt IV [this message]
2024-09-23 16:09 ` Shuah Khan
2024-09-05 2:19 ` [PATCH v3 3/4] pm:cpupower: Include test_raw_pylibcpupower.py John B. Wyatt IV
2024-09-05 2:19 ` [PATCH v3 4/4] MAINTAINERS: Add Maintainers for SWIG Python bindings John B. Wyatt IV
2024-09-06 1:03 ` [PATCH v3 0/4] Add SWIG Bindings to libcpupower Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvFtHM5465aOYX24@rhfedora \
--to=jwyatt@redhat.com \
--cc=acme@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=jkacur@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rafael@kernel.org \
--cc=sageofredondo@gmail.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=tglozar@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox