From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [PATCH v1 1/1] regmap-irq: Consistently use memset32() in regmap_irq_thread()
Date: Wed, 25 Sep 2024 12:02:30 +0300 [thread overview]
Message-ID: <ZvPRpmaUuR3JlUYY@smile.fi.intel.com> (raw)
In-Reply-To: <0b7b6ca3-b05b-40f2-86cf-083beb72727c@gmail.com>
On Wed, Sep 25, 2024 at 11:55:51AM +0300, Matti Vaittinen wrote:
> On 9/25/24 11:27, Andy Shevchenko wrote:
...
> > memset32(data->status_buf, GENMASK(31, 0), chip->num_regs);
> > - memset(data->status_buf, 0, size);
> > + memset32(data->status_buf, 0, chip->num_regs);
> Can we guarantee the sizeof(unsigned int) == sizeof(uint32_t) on all
> supported architectures? (The status_buf is unsigned int, right?). If yes,
> then this looks nice to me.
Yes as long as we (Linux kernel) support only 32-bit and higher architectures.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-25 9:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:27 [PATCH v1 1/1] regmap-irq: Consistently use memset32() in regmap_irq_thread() Andy Shevchenko
2024-09-25 8:55 ` Matti Vaittinen
2024-09-25 9:02 ` Andy Shevchenko [this message]
2024-10-01 11:13 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvPRpmaUuR3JlUYY@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox