From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0B22915B111 for ; Wed, 25 Sep 2024 23:51:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727308305; cv=none; b=mqaUnzF8GRUSsr/gOuJmQySr+8AF2uXgn7KNCQkSSArvV46A5QadC9gSaiFPTwxGQV+gquD4h5TkVmRvFBNTwPMZPmd69ctVlBUwQZdvpRIp1SobkULvb5j8rAyT7hkejkMU2wbeYmJuIE8OlvIDUpmF5QGo6mmtHPQXMpG0h74= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727308305; c=relaxed/simple; bh=1xkkLn1+bdfXFRs664y6k0DNdEOzPnQum3zjPar+uQA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=cz9nIBhUKPmt336HfsRtlznTsgMziOh8k/MEJSjOvwDKS56CWUeTNKG0PbuwpQK4/V9xArbjZEDBswTJH8B1LKC+lzFYjF2oD8NEcSphXWqSlJtL9l/IZevLsqH+OuaQLFq4r34JMySFqJ0VJv1aG7mDP9v5nX/jrBkTyB5sOEs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=tZ47c1lM; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="tZ47c1lM" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-206f9b872b2so3091285ad.3 for ; Wed, 25 Sep 2024 16:51:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1727308303; x=1727913103; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1xkkLn1+bdfXFRs664y6k0DNdEOzPnQum3zjPar+uQA=; b=tZ47c1lMIM2vNTCd5AeVsggWSTiNgVqTZOa+RPB4s+PzdTJUCtbTvDSvuTNwCHdbSy QMZQqYz0VDhwiZ9tPgfdsGZYTClos4POsILPRReey2zJDGffFBP/0aJkzXAnzS+9D3Lk t/hINlK6C1OUT9OxgRq84126Jd9yjyirZhaTzemcC7+IavO4cFsHR3ZStwBgEgEJBn6S Ei8unKxXWTYgfxEK/N4u2elBfbtRBde/OhtND6dTbSIW7mwteLJSQ3KBW7ibvOfST1HK 0wog0XE/h5LdBCZnzQ8gqRaC4/Ec2qhuDv/dRxxOSS3Qz5YVl7CmDs1gsXjHmuA/WiE7 Tzww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727308303; x=1727913103; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1xkkLn1+bdfXFRs664y6k0DNdEOzPnQum3zjPar+uQA=; b=h0PkZOtTSs1irpDZo8s4NH3YEzHtEJEWbUVLeqbd7JZr7NAxBmXtaFtGQJK2XRW3Ln jWXUwg4Fo5HVVEWQ7BYwMLNdySCDZ89/lFoqKk6f0h98QG2SIJXKGWExQ4l6cmTEpGq0 Ftaxsp3fkFgVx1zy+Mm4I+ha0a0FHCCZpPF+bjidNZdxAACT3NuulkIwnryIhjOBjdaw b9hlluS9/pW7e2W77iP1qCr1AL5qDL4AsibQmANWueMAIqt9LN8MDWTxd0mIr+4v3a4u fhCdTcpjBTIQ4YC6bKFtr1T2Zgk0lhIpfRoYn+9OZkyPE8RSm36FKW5y1SdOUgyMGQQW N4oA== X-Forwarded-Encrypted: i=1; AJvYcCWG12P9B5nVrXdvtA02JoF7nlggzkUbCzeoZPJ3TmXCGMUBfiHygJ7X3FZbJ65SlHnegX7yaCdUIOgSv8I=@vger.kernel.org X-Gm-Message-State: AOJu0YyC7DFuXytPJ/UXy5fEPaS2KbA35m0HrMmJOhtRGaFo16/NdS4E TSjbqWpkixjbypnGZAyVIN0NCWUL39kcRTOnx7P3hInaaJJhlsqiL6geuMrQEg== X-Google-Smtp-Source: AGHT+IE9Ra0Mr6+7MR0bMwuFLB9nweUy/yTnEXljqqFwo2FmQ7UofXMIzpM4C6eTw6mWhjDcDiRJEg== X-Received: by 2002:a17:902:daca:b0:202:3432:2324 with SMTP id d9443c01a7336-20afc6458d0mr59978055ad.54.1727308302921; Wed, 25 Sep 2024 16:51:42 -0700 (PDT) Received: from google.com (46.242.125.34.bc.googleusercontent.com. [34.125.242.46]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20af16e064bsm28782395ad.17.2024.09.25.16.51.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Sep 2024 16:51:42 -0700 (PDT) Date: Wed, 25 Sep 2024 16:51:37 -0700 From: David Matlack To: Vipin Sharma Cc: seanjc@google.com, pbonzini@redhat.com, zhi.wang.linux@gmail.com, weijiang.yang@intel.com, mizhang@google.com, liangchen.linux@gmail.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] KVM: x86/mmu: Repurpose MMU shrinker into page cache shrinker Message-ID: References: <20240913214316.1945951-1-vipinsh@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240913214316.1945951-1-vipinsh@google.com> On 2024-09-13 02:43 PM, Vipin Sharma wrote: > This series is extracted out from the NUMA aware page table series[1]. > MMU shrinker changes were in patches 1 to 9 in the old series. I'm curious how you tested this series. Would it be posisble to write a selftest to exercise KVM's shrinker interactions? I don't think it needs to be anything fancy to be useful (e.g. just run a VM, trigger lots of shrinking, and make sure nothing blows up). There appears to be a debugfs interface which could be used to trigger shrinking from a selftest. https://docs.kernel.org/admin-guide/mm/shrinker_debugfs.html