From: Johan Hovold <johan@kernel.org>
To: John Keeping <jkeeping@inmusicbrands.com>
Cc: linux-sound@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alex Elder <elder@kernel.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Lee Jones <lee@kernel.org>,
Francesco Dolcini <francesco.dolcini@toradex.com>,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
Rob Herring <robh@kernel.org>, Daniel Kaehn <kaehndan@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: serial-generic: explicitly disable flow control
Date: Fri, 27 Sep 2024 10:39:16 +0200 [thread overview]
Message-ID: <ZvZvNIOLX1UMJmC3@hovoldconsulting.com> (raw)
In-Reply-To: <20240926104404.3527124-1-jkeeping@inmusicbrands.com>
On Thu, Sep 26, 2024 at 11:44:03AM +0100, John Keeping wrote:
> The serdev subsystem does not specify the default state of flow control
> when opening a device.
This bit isn't correct as serdev enables hardware flow control (CRTSCTS)
by default on open() (see ttyport_open()).
> Surveying other drivers using serdev shows the
> vast majority of these set flow control explicitly after opening the
> device.
>
> MIDI does not use flow control, so ensure it is disabled.
Johan
prev parent reply other threads:[~2024-09-27 8:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-26 10:44 [PATCH] ALSA: serial-generic: explicitly disable flow control John Keeping
2024-09-27 8:39 ` Johan Hovold [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvZvNIOLX1UMJmC3@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=elder@kernel.org \
--cc=francesco.dolcini@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jkeeping@inmusicbrands.com \
--cc=kaehndan@gmail.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox