From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CF1C8212EF8 for ; Fri, 4 Oct 2024 14:03:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728050620; cv=none; b=on2FqaUU8OKwErnOtIgBMLgKGnntwQBsPWfXPM+rYcYVaE64ZdShDzoJi3l7g23PcIcn8rs9PdVqQ/agi/mtQS33vKMPCf8rNcoEkWchTr7gmEaNWn5ELU+iPd2Y8t+SAzn61OxeXGLW5FUi2t/aN4RlyiUfBzC7yxXIAM7qN00= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728050620; c=relaxed/simple; bh=zf53D21lgDvTB6JUEfxVqZbm+BFThNNWH3xiD7g2/co=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZcfY1/+SYiwGuGJwUM00z+Kz/okVAH+Tmhd9x6N9Xg4gaXBannU9tXC/34+tHr+io+7ARIjvR2YUlfUFQXhxB4IaiXmJwNYCiPy1rq/z3iiCb6L3LvxAANPA9ArPCyXY6rFdaIfdtIcfFL7cqf7vkKt6EeVLsTwUW7vGOu5nXcc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b=StHn2pU4; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="StHn2pU4" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 849B5C4CEC6; Fri, 4 Oct 2024 14:03:39 +0000 (UTC) Authentication-Results: smtp.kernel.org; dkim=pass (1024-bit key) header.d=zx2c4.com header.i=@zx2c4.com header.b="StHn2pU4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1728050617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ur282vCe+GXFVEXwlujjDhdyy2V/Vuv1h16vjS6nUtY=; b=StHn2pU4xLJWhZVZK448TxKQ6FtqpJbfgl4I87by9m2cpC6X/W8LL4Vb/d0ru61jMYw2Hg styy1k3tnm8bcS24kai8Q7kWTg4FzDsyQn22SHoEiwhDCmyRHZ1N6CGZFWqt+kb9GfXiLr 2UczYNwEOpZtn454CCVJ4STdz01xr8E= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id febb0452 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 4 Oct 2024 14:03:36 +0000 (UTC) Date: Fri, 4 Oct 2024 16:03:34 +0200 From: "Jason A. Donenfeld" To: Michael Ellerman Cc: Christophe Leroy , mpe@ellerman.id.au, Nicholas Piggin , Naveen N Rao , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: Re: [PATCH 2/2] powerpc/vdso: Implement __arch_get_vdso_rng_data() Message-ID: References: <0557d3ec898c1d0ea2fc59fa8757618e524c5d94.1727858295.git.christophe.leroy@csgroup.eu> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: On Fri, Oct 04, 2024 at 08:52:40PM +1000, Michael Ellerman wrote: > > > On October 4, 2024 2:33:54 AM GMT+10:00, "Jason A. Donenfeld" wrote: > >Hey Christophe, Michael, > > > >This series actually looks pretty okay to me. I realize ThomasW is > >working on more generic cleanups that might obliterate the need for > >this, and that may or may not wind up in 6.13. But, I was thinking, this > >seems like a good correct thing to do, and to do it now for 6.12, maybe > >as a fix through the powerpc tree. Then ThomasW can base his work atop > >this, which might wind up including the nice lr optimizations you've > >made. And then also if ThomasW's work doesn't land or gets reverted or > >whatever, at least we'll have this in tree for 6.12. > > > >Michael - what do you think of that? Worth taking these two patches into > >your fixes? > > I agree the series looks good. But they're not fixes by my reading, so I'd be inclined to put them in next for v6.13? They're "close enough" to fixes. The get_realdatapage stuff is super wonky and weird and it's quite good Christophe has gotten rid of it. Returning NULL from the generic accesor function never really sat right and looks buggy even if it does work. But more to the point, given the other scheduled churn for 6.13, it's going to be a tree-clashing nightmare to get this in later. And this Sunday is rc2 only, so why not. Jason