From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: maorg@nvidia.com, bharat@chelsio.com, jgg@ziepe.ca
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: of c4iw_fill_res_qp_entry
Date: Fri, 4 Oct 2024 14:16:08 +0000 [thread overview]
Message-ID: <Zv_4qAxuC0dLmgXP@gallifrey> (raw)
Hi,
One of my scripts noticed that c4iw_fill_res_qp_entry is not called
anywhere; It came from:
commit 5cc34116ccec60032dbaa92768f41e95ce2d8ec7
Author: Maor Gottlieb <maorg@mellanox.com>
Date: Tue Jun 23 14:30:38 2020 +0300
RDMA: Add dedicated QP resource tracker function
I was going to send a patch to deadcode it, but is it really a bug and
it should be assigned in c4iw_dev_ops in cxgb4/provider.c ?
(Note I know nothing about the innards of your driver, I'm just spotting
the unused function).
Thoughts?
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
next reply other threads:[~2024-10-04 14:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-04 14:16 Dr. David Alan Gilbert [this message]
2024-10-06 14:05 ` of c4iw_fill_res_qp_entry Leon Romanovsky
2024-10-06 14:28 ` Dr. David Alan Gilbert
2024-10-07 16:05 ` Leon Romanovsky
2024-10-07 16:44 ` Dr. David Alan Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zv_4qAxuC0dLmgXP@gallifrey \
--to=linux@treblig.org \
--cc=bharat@chelsio.com \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=maorg@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox