The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Yury Norov <yury.norov@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Rasmus Villemoes <linux@rasmusvillemoes.dk>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Brian Norris <briannorris@chromium.org>
Subject: Re: [GIT PULL] bitmap changes for v6.12-rc1
Date: Fri, 27 Sep 2024 13:08:40 -0700	[thread overview]
Message-ID: <ZvcQyAw27hdRZw2B@yury-ThinkPad> (raw)
In-Reply-To: <CAHk-=wjS9O67Ue9fZWG4ptc-MyZchqJmQFsMJkOchqpnxc-Dvw@mail.gmail.com>

On Fri, Sep 27, 2024 at 12:37:06PM -0700, Linus Torvalds wrote:
> On Fri, 27 Sept 2024 at 09:32, Yury Norov <yury.norov@gmail.com> wrote:
> >
> > GENMASK_U128() is a prerequisite needed for arm64 development.
> 
> Note that at least right now, __int128 is marked as conditional for arm64:
> 
>         select ARCH_SUPPORTS_INT128 if CC_HAS_INT128
> 
> which implies that we may have compiler versions that don't actually
> support it at all.
> 
> That said, I'm not sure what those compiler versions might be. Maybe
> this is historical copy-and-paste noise.

Thanks for pointing at this.

So, GCC documentation says that __int128 is an extension, and
CC_HAS_INT128 in init/Kconfig tests for it. All existing code that
uses 128-bit types is protected with the config you mentioned, or
directly with #ifdef __SIZEOF_INT128__. So the GENMASK_U128 should.

I'll drop GENMASK_U128() part from the request and send v2 later today.

Anshuman, can you please make GENMASK_U128() conditional based on
CONFIG_ARCH_SUPPORTS_INT128 and resend?

Thanks,
Yury

  reply	other threads:[~2024-09-27 20:08 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-27 16:32 [GIT PULL] bitmap changes for v6.12-rc1 Yury Norov
2024-09-27 19:37 ` Linus Torvalds
2024-09-27 20:08   ` Yury Norov [this message]
2024-09-27 20:29     ` Linus Torvalds
2024-09-27 20:00 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvcQyAw27hdRZw2B@yury-ThinkPad \
    --to=yury.norov@gmail.com \
    --cc=anshuman.khandual@arm.com \
    --cc=briannorris@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@rasmusvillemoes.dk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox