* [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
@ 2024-09-26 15:51 Abhishek Tamboli
2024-09-26 16:12 ` Shuah Khan
2024-09-30 8:09 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Abhishek Tamboli @ 2024-09-26 15:51 UTC (permalink / raw)
To: perex, tiwai
Cc: kailang, sbinding, simont, josh, foss, rf, skhan, rbmarliere,
linux-kernel-mentees, linux-sound, linux-kernel
Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
quirk for this model.
Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
---
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 4ca66234e561..94125a977f08 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
+ SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
--
2.34.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
2024-09-26 15:51 [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200 Abhishek Tamboli
@ 2024-09-26 16:12 ` Shuah Khan
2024-09-28 2:14 ` Abhishek Tamboli
2024-09-30 8:09 ` Takashi Iwai
1 sibling, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2024-09-26 16:12 UTC (permalink / raw)
To: Abhishek Tamboli, perex, tiwai
Cc: kailang, sbinding, simont, josh, foss, rf, rbmarliere,
linux-kernel-mentees, linux-sound, linux-kernel, Shuah Khan
On 9/26/24 09:51, Abhishek Tamboli wrote:
> Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> quirk for this model.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
Were you able to test this on HP Pavilion Gaming laptop? If so
please add that to the change log.
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ca66234e561..94125a977f08 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
Looks like this has been fixed:
https://lore.kernel.org/lkml/20220918171300.24693-1-dhould3@gmail.com/t/#m0c6aeebe5cc89c9a4228d49f56f4a0a4c516e012
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
2024-09-26 16:12 ` Shuah Khan
@ 2024-09-28 2:14 ` Abhishek Tamboli
0 siblings, 0 replies; 5+ messages in thread
From: Abhishek Tamboli @ 2024-09-28 2:14 UTC (permalink / raw)
To: Shuah Khan
Cc: perex, tiwai, kailang, sbinding, simont, josh, foss, rf,
rbmarliere, linux-kernel-mentees, linux-sound, linux-kernel
Hi Shuah,
Thanks for the feedback.
On Thu, Sep 26, 2024 at 10:12:03AM -0600, Shuah Khan wrote:
> On 9/26/24 09:51, Abhishek Tamboli wrote:
> > Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> > enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> > quirk for this model.
>
> Were you able to test this on HP Pavilion Gaming laptop? If so
> please add that to the change log.
The person who reported the bug confirmed that the patch resolved
the issue on his device.
For your reference: https://bugzilla.kernel.org/show_bug.cgi?id=219303
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> > ---
> > sound/pci/hda/patch_realtek.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 4ca66234e561..94125a977f08 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> > SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>
> Looks like this has been fixed:
>
> https://lore.kernel.org/lkml/20220918171300.24693-1-dhould3@gmail.com/t/#m0c6aeebe5cc89c9a4228d49f56f4a0a4c516e012
No, this patch seems to be for the HP OMEN 16.
Thanks,
Abhishek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
2024-09-26 15:51 [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200 Abhishek Tamboli
2024-09-26 16:12 ` Shuah Khan
@ 2024-09-30 8:09 ` Takashi Iwai
2024-09-30 14:51 ` Abhishek Tamboli
1 sibling, 1 reply; 5+ messages in thread
From: Takashi Iwai @ 2024-09-30 8:09 UTC (permalink / raw)
To: Abhishek Tamboli
Cc: perex, tiwai, kailang, sbinding, simont, josh, foss, rf, skhan,
rbmarliere, linux-kernel-mentees, linux-sound, linux-kernel
On Thu, 26 Sep 2024 17:51:12 +0200,
Abhishek Tamboli wrote:
>
> Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> quirk for this model.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
>
> Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> ---
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 4ca66234e561..94125a977f08 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
The quirk table is sorted in PCI SSID order. Could you try to put at
the right position?
Also, please use lower letters for the hex numbers there.
thanks,
Takashi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200
2024-09-30 8:09 ` Takashi Iwai
@ 2024-09-30 14:51 ` Abhishek Tamboli
0 siblings, 0 replies; 5+ messages in thread
From: Abhishek Tamboli @ 2024-09-30 14:51 UTC (permalink / raw)
To: Takashi Iwai
Cc: perex, tiwai, kailang, sbinding, simont, josh, foss, rf, skhan,
rbmarliere, linux-kernel-mentees, linux-sound, linux-kernel
Hi Takashi,
Thanks for the feedback.
On Mon, Sep 30, 2024 at 10:09:02AM +0200, Takashi Iwai wrote:
> On Thu, 26 Sep 2024 17:51:12 +0200,
> Abhishek Tamboli wrote:
> >
> > Add the quirk for HP Pavilion Gaming laptop 15z-ec200 for
> > enabling the mute led. The fix apply the ALC285_FIXUP_HP_MUTE_LED
> > quirk for this model.
> >
> > Link: https://bugzilla.kernel.org/show_bug.cgi?id=219303
> >
> > Signed-off-by: Abhishek Tamboli <abhishektamboli9@gmail.com>
> > ---
> > sound/pci/hda/patch_realtek.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> > index 4ca66234e561..94125a977f08 100644
> > --- a/sound/pci/hda/patch_realtek.c
> > +++ b/sound/pci/hda/patch_realtek.c
> > @@ -10315,6 +10315,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> > SND_PCI_QUIRK(0x103c, 0x8786, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x8787, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x8788, "HP OMEN 15", ALC285_FIXUP_HP_MUTE_LED),
> > + SND_PCI_QUIRK(0x103c, 0x88DD, "HP Pavilion 15z-ec200", ALC285_FIXUP_HP_MUTE_LED),
> > SND_PCI_QUIRK(0x103c, 0x87b7, "HP Laptop 14-fq0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
> > SND_PCI_QUIRK(0x103c, 0x87c8, "HP", ALC287_FIXUP_HP_GPIO_LED),
> > SND_PCI_QUIRK(0x103c, 0x87d3, "HP Laptop 15-gw0xxx", ALC236_FIXUP_HP_MUTE_LED_COEFBIT2),
>
> The quirk table is sorted in PCI SSID order. Could you try to put at
> the right position?
Ok I will put it in the order.
> Also, please use lower letters for the hex numbers there.
Sure.
Thanks,
Abhishek
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-09-30 14:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-26 15:51 [PATCH] ALSA: hda/realtek: Add a quirk for HP Pavilion 15z-ec200 Abhishek Tamboli
2024-09-26 16:12 ` Shuah Khan
2024-09-28 2:14 ` Abhishek Tamboli
2024-09-30 8:09 ` Takashi Iwai
2024-09-30 14:51 ` Abhishek Tamboli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox