From: Lukas Wunner <lukas@wunner.de>
To: Maxim Mikityanskiy <maxtram95@gmail.com>
Cc: Takashi Iwai <tiwai@suse.de>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
Rui Salvaterra <rsalvaterra@gmail.com>,
Sui Jingfeng <suijingfeng@loongson.cn>,
Bjorn Helgaas <bhelgaas@google.com>,
Peter Wu <peter@lekensteyn.nl>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound
Date: Mon, 30 Sep 2024 11:15:54 +0200 [thread overview]
Message-ID: <ZvpsSjgDFd-pbzFW@wunner.de> (raw)
In-Reply-To: <ZvpTRLxSkcqn03Fk@mail.gmail.com>
On Mon, Sep 30, 2024 at 10:29:08AM +0300, Maxim Mikityanskiy wrote:
> Anyways, adding a DMI check to hda_intel or quirk_nvidia_hda seems the
> same level of efforts, so I can proceed with the former. It's the same
> power consumption either way, right?
>
> I'm also thinking of adding a module parameter to block probing of the
> DGPU audio. Back in the days, there were plenty of similar Lenovo
> laptops, which might also suffer from the same issue.
Adding new command line parameters for hardware quirks is generally
frowned upon these days and is usually greeted by Greg KH's trademark
"this isn't the 1990s anymore" comment.
Drivers are supposed to auto-detect hardware with quirks and handle
them correctly without the user having to add a command line option.
Users should not get accustomed to fiddling with the command line.
They won't have the need to report broken hardware and the driver
may never be amended to deal with affected models automatically.
Thanks,
Lukas
next prev parent reply other threads:[~2024-09-30 9:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 20:39 [PATCH] ALSA: hda: intel: Fix Optimus when GPU has no sound Maxim Mikityanskiy
2024-09-05 14:24 ` Takashi Iwai
2024-09-06 18:05 ` Maxim Mikityanskiy
2024-09-07 10:06 ` Takashi Iwai
2024-09-07 13:45 ` Maxim Mikityanskiy
2024-09-07 15:49 ` Takashi Iwai
2024-09-07 17:24 ` Maxim Mikityanskiy
2024-09-07 18:10 ` Takashi Iwai
2024-09-21 8:10 ` Maxim Mikityanskiy
2024-09-30 6:43 ` Takashi Iwai
2024-09-30 7:29 ` Maxim Mikityanskiy
2024-09-30 9:15 ` Lukas Wunner [this message]
2024-09-30 10:50 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvpsSjgDFd-pbzFW@wunner.de \
--to=lukas@wunner.de \
--cc=bhelgaas@google.com \
--cc=chaitanya.kumar.borah@intel.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxtram95@gmail.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=peter@lekensteyn.nl \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rsalvaterra@gmail.com \
--cc=suijingfeng@loongson.cn \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox