From: Tony Ambardar <tony.ambardar@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>,
Daniel Borkmann <daniel@iogearbox.net>,
Miguel Ojeda <ojeda@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compiler-gcc.h: Disable __retain on gcc-11
Date: Mon, 30 Sep 2024 16:51:00 -0700 [thread overview]
Message-ID: <Zvs5ZHCc4MGkE8XK@kodidev-ubuntu> (raw)
In-Reply-To: <87bk0d2c51.fsf@igel.home>
On Tue, Sep 24, 2024 at 07:29:46PM +0200, Andreas Schwab wrote:
> On Sep 24 2024, Geert Uytterhoeven wrote:
>
> > All my gcc-11 compilers (Ubuntu 11.4.0-1ubuntu1~22.04) claim to support
> > the __retain__ attribute, but only riscv64-linux-gnu-gcc-11 and
> > x86_64-linux-gnu-gcc-11 (not x86_64-linux-gnux32-gcc-11!) actually do.
> > The arm-linux-gnueabi-gcc-11.5.0 compiler from kernel.org crosstool
> > fails in the same way:
> >
> > error: ‘retain’ attribute ignored [-Werror=attributes]
> >
> > All my gcc-12 compilers seem to support the attribute.
>
> That ultimately depends on binutils support for SHF_GNU_RETAIN (2.36+).
IIRC from working on the original patch, older linkers which do not
support this 'R' flag would simply ignore it and not error out, making
binutils compatibility less of an issue.
>
> --
> Andreas Schwab, schwab@linux-m68k.org
> GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1
> "And now for something completely different."
next prev parent reply other threads:[~2024-09-30 23:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-24 13:55 [PATCH] compiler-gcc.h: Disable __retain on gcc-11 Geert Uytterhoeven
2024-09-24 17:21 ` Miguel Ojeda
2024-09-24 18:30 ` Geert Uytterhoeven
2024-09-30 23:50 ` Tony Ambardar
2024-10-01 15:32 ` Miguel Ojeda
2024-09-24 17:29 ` Andreas Schwab
2024-09-30 23:51 ` Tony Ambardar [this message]
2024-10-01 17:45 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvs5ZHCc4MGkE8XK@kodidev-ubuntu \
--to=tony.ambardar@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=daniel@iogearbox.net \
--cc=geert+renesas@glider.be \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox