public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Fix system hang on resume after hot-unplug during suspend
Date: Tue, 1 Oct 2024 13:07:18 +0200	[thread overview]
Message-ID: <ZvvX5i95MpWrru4_@wunner.de> (raw)
In-Reply-To: <CAFv23Q=QJ+SmpwvzLmzJeCXwYrAHVvTK96Wz7rY=df7VmGbSmw@mail.gmail.com>

On Mon, Sep 30, 2024 at 11:27:28AM +0800, AceLan Kao wrote:
> Lukas Wunner <lukas@wunner.de> 2024 9 27 5:28
> > there is a known issue
> > that a deadlock may occur when hot-removing nested PCIe switches (which is
> > what you've got here).  Keith Busch recently re-discovered the issue.
> > You may want to try if the hang goes away if you apply this patch:
> >
> > https://lore.kernel.org/all/20240612181625.3604512-2-kbusch@meta.com/
> >
> > If it does go away then at least we know what the root cause is.
> 
> Yes, the 2 patches work.

Okay so you can't reproduce the issue with those patches?

That would mean 9d573d19547b ("PCI: pciehp: Detect device replacement
during system sleep") isn't the culprit, whew!


> > The patch is a bit hackish, but there's an ongoing effort to tackle the
> > problem more thoroughly:
> >
> > https://lore.kernel.org/all/20240722151936.1452299-1-kbusch@meta.com/
> > https://lore.kernel.org/all/20240827192826.710031-1-kbusch@meta.com/
> 
> v2 can't be applied clearly, so I made some changes.
> And this series doesn't work for me.

Okay, I'll look at those patches separately.

Thanks,

Lukas

      reply	other threads:[~2024-10-01 11:07 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-26 12:59 [PATCH] PCI: pciehp: Fix system hang on resume after hot-unplug during suspend Chia-Lin Kao (AceLan)
2024-09-26 13:23 ` Lukas Wunner
2024-09-27  7:33   ` AceLan Kao
2024-09-27  9:28     ` Lukas Wunner
2024-09-28 12:51       ` Lukas Wunner
2024-09-30  1:31         ` AceLan Kao
2024-10-01 11:02           ` Lukas Wunner
2024-10-01 11:03             ` Lukas Wunner
2024-10-07  4:34               ` AceLan Kao
2024-10-17  2:40                 ` AceLan Kao
2024-10-22 13:05                   ` AceLan Kao
2024-10-23  4:23                   ` Ethan Zhao
2024-09-30  3:27       ` AceLan Kao
2024-10-01 11:07         ` Lukas Wunner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZvvX5i95MpWrru4_@wunner.de \
    --to=lukas@wunner.de \
    --cc=acelan.kao@canonical.com \
    --cc=bhelgaas@google.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox