From: Tejun Heo <tj@kernel.org>
To: "Matthias Männich" <maennich@google.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
peterz@infradead.org, void@manifault.com
Subject: Re: [PATCH] sched: fix include for task_cpu_possible
Date: Tue, 1 Oct 2024 09:46:34 -1000 [thread overview]
Message-ID: <ZvxRmiro3oE4hDgO@slm.duckdns.org> (raw)
In-Reply-To: <Zvs42l4A9wvqnLFK@google.com>
On Mon, Sep 30, 2024 at 11:48:42PM +0000, Matthias Männich wrote:
> > Should the patch also remove mmu_context.h from kernel/sched/core.c?
>
> kernel/sched/core.c has a call to switch_mm_irqs_off, which is defined
> in linux/mmu_context.h as well. So, no, the original include needs to
> remain.
Hmm... I'm a bit confused. kernel/sched/core.c always includes
kernel/sched/sched.h which collects all the shared includes. Why does it
need to be repeated in core.c?
Thanks.
--
tejun
prev parent reply other threads:[~2024-10-01 19:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-30 16:44 [PATCH] sched: fix include for task_cpu_possible Matthias Männich
2024-09-30 17:02 ` Tejun Heo
2024-09-30 23:48 ` Matthias Männich
2024-10-01 19:46 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvxRmiro3oE4hDgO@slm.duckdns.org \
--to=tj@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maennich@google.com \
--cc=peterz@infradead.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox