From: Vishal Chourasia <vishalc@linux.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: David Vernet <void@manifault.com>, Josh Don <joshdon@google.com>,
Hao Luo <haoluo@google.com>, Barret Rhoden <brho@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: sched_ext: build errors when building flatcg and qmap schedulers
Date: Wed, 2 Oct 2024 10:47:53 +0530 [thread overview]
Message-ID: <ZvzXarv10LVGteNd@linux.ibm.com> (raw)
In-Reply-To: <Zvxfg-Qpn_oO6qTh@slm.duckdns.org>
On Tue, Oct 01, 2024 at 10:45:55AM -1000, Tejun Heo wrote:
> Hello, Vishal.
>
> On Tue, Oct 01, 2024 at 05:08:58PM +0530, Vishal Chourasia wrote:
> > Getting build error when trying to compile example schedulers in
> > tools/sched_ext/* (logs shared in the end)
> >
> >
> > tools/sched_ext # make -s -k
> >
> >
> > git repo state
> > $ git log --oneline
> > e32cde8d2bd7d (HEAD -> master, origin/master, origin/HEAD) Merge tag 'sched_ext-for-6.12-rc1-fixes-1' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext
> > 190ecde722dd0 Merge tag 'probes-fixes-v6.12-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace
> > a5f24c795513f Merge tag 'vfs-6.12-rc2.fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs
> > f801850bc263d netfs: Fix the netfs_folio tracepoint to handle NULL mapping
> > 28e8c5c095ec2 netfs: Add folio_queue API documentation
> > 2007d28ec0095 bcachefs: rename version -> bversion for big endian builds
> > 34820304cc2cd uprobes: fix kernel info leak via "[uprobes]" vma
> > 9852d85ec9d49 (tag: v6.12-rc1) Linux 6.12-rc1
> >
> >
> > Adding __weak attribute seems to have fixed it and compilation completed
> > with no errors.
>
> Hmm... I don't see the failure here. Maybe toolchain difference? Anyways,
$ clang --version
clang version 20.0.0git (https://github.com/llvm/llvm-project.git 00c198b2ca6b6bee2d90e62d78816686ab056b1b)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/local/bin
$ gcc --version
gcc (GCC) 14.2.1 20240912 (Red Hat 14.2.1-3)
Copyright (C) 2024 Free Software Foundation, Inc.
This is free software; see the source for copying conditions. There is NO
warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
Do let me know if you need any other information
> can you send the patch to add __weak?
Sure.
>
> Thanks.
>
> --
> tejun
prev parent reply other threads:[~2024-10-02 5:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-01 11:38 sched_ext: build errors when building flatcg and qmap schedulers Vishal Chourasia
2024-10-01 20:45 ` Tejun Heo
2024-10-02 5:17 ` Vishal Chourasia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvzXarv10LVGteNd@linux.ibm.com \
--to=vishalc@linux.ibm.com \
--cc=brho@google.com \
--cc=haoluo@google.com \
--cc=joshdon@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=void@manifault.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox