From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: linux-kbuild@vger.kernel.org,
Tero Kristo <tero.kristo@linux.intel.com>,
platform-driver-x86@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Hans de Goede <hdegoede@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
David Gow <davidgow@google.com>,
Masahiro Yamada <masahiroy@kernel.org>
Subject: Re: [rfc, PATCH v1 1/1] platform/x86: intel: Add 'intel' prefix to the modules automatically
Date: Tue, 15 Oct 2024 14:01:15 +0300 [thread overview]
Message-ID: <Zw5Lew9I3YG_apPx@smile.fi.intel.com> (raw)
In-Reply-To: <caa4b5e0-742b-a4f4-d4c8-8e14cc99eefc@linux.intel.com>
On Tue, Oct 15, 2024 at 12:05:45PM +0300, Ilpo Järvinen wrote:
> On Fri, 11 Oct 2024, Andy Shevchenko wrote:
>
> > Rework Makefile to add 'intel' prefix to the modules automatically.
> > This removes a lot of boilerplate code in it and also makes robust
> > against mistypos in the prefix.
...
> > Send as RFC because TBH I rather want to have something like this to be
> > available on the level of Kbuild for any of the subdirectories in
> > question. Also I haven't done any comprehensive build tests on this,
> > let's see what CIs think about this...
>
> It feels useful to have this automatically available for the folder one
> level towards root... (perhaps two levels).
Yeah, ideally for a few levels of folders, but at least one would be useful
to start with.
> But you didn't include kbuild ML (now added).
I'll do it in v2.
...
> Why call these intel-target-*, wouldn't intel-obj-* be more consistent?
The (potential) problem with obj as it may collide with the standard way of
collecting objects under meta one (which will become a real module). I haven't
tested that but I believe that putting anything to FOO-obj-y/m is a carefully
placed minefield, if not now, then later. That said, I would avoid using obj
there.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-10-15 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 17:24 [rfc, PATCH v1 1/1] platform/x86: intel: Add 'intel' prefix to the modules automatically Andy Shevchenko
2024-10-11 17:41 ` Andy Shevchenko
2024-10-15 9:05 ` Ilpo Järvinen
2024-10-15 11:01 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zw5Lew9I3YG_apPx@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=davidgow@google.com \
--cc=geert@linux-m68k.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tero.kristo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox