Re: [PATCH v1 0/3] pinctrl: th1520: Unbreak the driver

Drew Fustini
2024-10-11T16:15:04Z

On Fri, Oct 11, 2024 at 04:48:22PM +0200, Emil Renner Berthing wrote:
> Hi,
>
> Here are 2 important fixes and a code improvement to the T-Head TH1520
> pinctrl driver that was either introduced or missed when Drew took over
> upstreaming it.
>
> It is based on Linus' pinctrl/for-next:
>
> 6dbd1577b7dc ("Merge branch 'devel' into for-next")
>
> Emil Renner Berthing (3):
> pinctrl: th1520: Fix pinconf return values
> pinctrl: th1520: Update pinmux tables
> pinctrl: th1520: Factor out casts
>
> drivers/pinctrl/pinctrl-th1520.c | 52 ++++++++++++++++++++------------
> 1 file changed, 32 insertions(+), 20 deletions(-)
>
> --
> 2.43.0

Emil informed me that the out-of-tree USB driver is broken when trying
to use the pinctrl-th1520 driver that I submitted. This is because I
had changed -ENOTSUPP to -EOPNOTSUPP to silence a checkpatch warning
without realizing the implication. I've just been working on the
dwmac etherenet series [1] on top of mainline and I didn't realize there
was a problem with gpio.

I've just rebuilt and booted okay on lpi4a and beaglev ahead with this
series. For the whole series:

Tested-by: Drew Fustini <dfustini@tenstorrent.com>

[1] https://lore.kernel.org/linux-riscv/20240930-th1520-dwmac-v3-0-ae3e03c225ab@tenstorrent.com/