Re: [PATCH 5/8] perf tools: Detect missing kernel features properly

[Namhyung Kim <namhyung@kernel.org>]

On Tue, Oct 15, 2024 at 09:49:52AM +0530, Ravi Bangoria wrote:
> > -	} else if (evsel->core.attr.exclude_guest || evsel->core.attr.exclude_host) {
> > -		if (evsel->pmu == NULL)
> > -			evsel->pmu = evsel__find_pmu(evsel);
> > -
> > -		if (evsel->pmu)
> > -			evsel->pmu->missing_features.exclude_guest = true;
> > -		else {
> > -			/* we cannot find PMU, disable attrs now */
> > -			evsel->core.attr.exclude_host = false;
> > -			evsel->core.attr.exclude_guest = false;
> > -		}
> >  
> > -		if (evsel->exclude_GH) {
> > -			pr_debug2_peo("PMU has no exclude_host/guest support, bailing out\n");
> > -			return false;
> > -		}
> > -		if (!perf_missing_features.exclude_guest) {
> > -			perf_missing_features.exclude_guest = true;
> > -			pr_debug2_peo("switching off exclude_guest, exclude_host\n");
> > -		}
> 
> Shall we get rid of:
> 
>   perf_missing_features.exclude_guest
>   pmu->missing_features.exclude_guest
> 
> they don't seem to be used anywhere after the patch.

Hmm.. it's my bad.  I think we should keep it for ancient kernels.

Thanks,
Namhyung