From: Herbert Xu <herbert@gondor.apana.org.au>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "Horia Geantă" <horia.geanta@nxp.com>,
"Pankaj Gupta" <pankaj.gupta@nxp.com>,
"Gaurav Jain" <gaurav.jain@nxp.com>,
"David S. Miller" <davem@davemloft.net>,
"Andrey Smirnov" <andrew.smirnov@gmail.com>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/2] crypto: caam: Fix the pointer passed to caam_qi_shutdown()
Date: Sat, 5 Oct 2024 13:31:50 +0800 [thread overview]
Message-ID: <ZwDPRsqCIphpCiHP@gondor.apana.org.au> (raw)
In-Reply-To: <c76ff86fe3ec40776646f4e5ebd5f0900ca48b37.1726395689.git.christophe.jaillet@wanadoo.fr>
On Sun, Sep 15, 2024 at 12:22:12PM +0200, Christophe JAILLET wrote:
> The type of the last parameter given to devm_add_action_or_reset() is
> "struct caam_drv_private *", but in caam_qi_shutdown(), it is casted to
> "struct device *".
>
> Pass the correct parameter to devm_add_action_or_reset() so that the
> resources are released as expected.
>
> Fixes: f414de2e2fff ("crypto: caam - use devres to de-initialize QI")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> This patch is speculative review with care.
> ---
> drivers/crypto/caam/qi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
All applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2024-10-05 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-15 10:22 [PATCH 1/2] crypto: caam: Fix the pointer passed to caam_qi_shutdown() Christophe JAILLET
2024-09-15 10:22 ` [PATCH 2/2] crypto: caam: Slightly simplify platform_device() Christophe JAILLET
2024-10-05 5:31 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwDPRsqCIphpCiHP@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=andrew.smirnov@gmail.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=gaurav.jain@nxp.com \
--cc=horia.geanta@nxp.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox