* [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android
@ 2024-09-14 3:11 Zhiguo Niu
2024-09-19 1:23 ` Zhiguo Niu
0 siblings, 1 reply; 3+ messages in thread
From: Zhiguo Niu @ 2024-09-14 3:11 UTC (permalink / raw)
To: jaegeuk, chao
Cc: linux-f2fs-devel, linux-kernel, niuzhiguo84, zhiguo.niu, ke.wang,
Hao_hao.Wang, xiuhong.wang
When 16K page/block size is enabled in Android platform,
a error maybe detected in mount process in kernel if "-b"
parameters is not specified in mkfs.f2fs.
Just as the following check:
if (le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE_BITS)
So use getpagesize() to get correct default blocksize.
Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
---
lib/libf2fs.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/lib/libf2fs.c b/lib/libf2fs.c
index ecd22d4..98ee0ae 100644
--- a/lib/libf2fs.c
+++ b/lib/libf2fs.c
@@ -685,8 +685,17 @@ void f2fs_init_configuration(void)
memset(&c, 0, sizeof(struct f2fs_configuration));
c.ndevs = 1;
+#ifdef WITH_ANDROID
+ c.blksize = getpagesize();
+ c.blksize_bits = log_base_2(c.blksize);
+ if ((1 << c.blksize_bits) != c.blksize) {
+ c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
+ c.blksize_bits = DEFAULT_BLKSIZE_BITS;
+ }
+#else
c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
c.blksize_bits = DEFAULT_BLKSIZE_BITS;
+#endif
c.sectors_per_blk = DEFAULT_SECTORS_PER_BLOCK;
c.blks_per_seg = DEFAULT_BLOCKS_PER_SEGMENT;
c.wanted_total_sectors = -1;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android
2024-09-14 3:11 [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android Zhiguo Niu
@ 2024-09-19 1:23 ` Zhiguo Niu
2024-10-07 16:49 ` Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Zhiguo Niu @ 2024-09-19 1:23 UTC (permalink / raw)
To: Zhiguo Niu; +Cc: jaegeuk, chao, linux-f2fs-devel, linux-kernel, xiuhong.wang
Hi all,
please ignore this patch, we can resove this by "-b" parameter .
thanks!
Zhiguo Niu <zhiguo.niu@unisoc.com> 于2024年9月14日周六 11:12写道：
>
> When 16K page/block size is enabled in Android platform,
> a error maybe detected in mount process in kernel if "-b"
> parameters is not specified in mkfs.f2fs.
> Just as the following check:
> if (le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE_BITS)
>
> So use getpagesize() to get correct default blocksize.
>
> Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
> ---
> lib/libf2fs.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/lib/libf2fs.c b/lib/libf2fs.c
> index ecd22d4..98ee0ae 100644
> --- a/lib/libf2fs.c
> +++ b/lib/libf2fs.c
> @@ -685,8 +685,17 @@ void f2fs_init_configuration(void)
>
> memset(&c, 0, sizeof(struct f2fs_configuration));
> c.ndevs = 1;
> +#ifdef WITH_ANDROID
> + c.blksize = getpagesize();
> + c.blksize_bits = log_base_2(c.blksize);
> + if ((1 << c.blksize_bits) != c.blksize) {
> + c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
> + c.blksize_bits = DEFAULT_BLKSIZE_BITS;
> + }
> +#else
> c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
> c.blksize_bits = DEFAULT_BLKSIZE_BITS;
> +#endif
> c.sectors_per_blk = DEFAULT_SECTORS_PER_BLOCK;
> c.blks_per_seg = DEFAULT_BLOCKS_PER_SEGMENT;
> c.wanted_total_sectors = -1;
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android
2024-09-19 1:23 ` Zhiguo Niu
@ 2024-10-07 16:49 ` Jaegeuk Kim
0 siblings, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2024-10-07 16:49 UTC (permalink / raw)
To: Zhiguo Niu; +Cc: Zhiguo Niu, chao, linux-f2fs-devel, linux-kernel, xiuhong.wang
On 09/19, Zhiguo Niu wrote:
> Hi all,
> please ignore this patch, we can resove this by "-b" parameter .
> thanks!
Ok, thanks.
> Zhiguo Niu <zhiguo.niu@unisoc.com> 于2024年9月14日周六 11:12写道：
> >
> > When 16K page/block size is enabled in Android platform,
> > a error maybe detected in mount process in kernel if "-b"
> > parameters is not specified in mkfs.f2fs.
> > Just as the following check:
> > if (le32_to_cpu(raw_super->log_blocksize) != F2FS_BLKSIZE_BITS)
> >
> > So use getpagesize() to get correct default blocksize.
> >
> > Signed-off-by: Zhiguo Niu <zhiguo.niu@unisoc.com>
> > Signed-off-by: Xiuhong Wang <xiuhong.wang@unisoc.com>
> > ---
> > lib/libf2fs.c | 9 +++++++++
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/lib/libf2fs.c b/lib/libf2fs.c
> > index ecd22d4..98ee0ae 100644
> > --- a/lib/libf2fs.c
> > +++ b/lib/libf2fs.c
> > @@ -685,8 +685,17 @@ void f2fs_init_configuration(void)
> >
> > memset(&c, 0, sizeof(struct f2fs_configuration));
> > c.ndevs = 1;
> > +#ifdef WITH_ANDROID
> > + c.blksize = getpagesize();
> > + c.blksize_bits = log_base_2(c.blksize);
> > + if ((1 << c.blksize_bits) != c.blksize) {
> > + c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
> > + c.blksize_bits = DEFAULT_BLKSIZE_BITS;
> > + }
> > +#else
> > c.blksize = 1 << DEFAULT_BLKSIZE_BITS;
> > c.blksize_bits = DEFAULT_BLKSIZE_BITS;
> > +#endif
> > c.sectors_per_blk = DEFAULT_SECTORS_PER_BLOCK;
> > c.blks_per_seg = DEFAULT_BLOCKS_PER_SEGMENT;
> > c.wanted_total_sectors = -1;
> > --
> > 1.9.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-07 16:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-14 3:11 [PATCH] f2fs-toos: use getpagesize() to get default blocksize in Android Zhiguo Niu
2024-09-19 1:23 ` Zhiguo Niu
2024-10-07 16:49 ` Jaegeuk Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox