Re: [PATCH net-next 12/12] net: pse-pd: tps23881: Add support for PSE events and interrupts

Kory Maincent
2024-10-09T08:25:33Z

On Wed, 9 Oct 2024 09:25:10 +0200
Oleksij Rempel <o.rempel@pengutronix.de> wrote:

> > +
> > + if (val & (TPS23881_REG_IT_IFAULT | TPS23881_REG_IT_IFAULT << 8)) {
> > + ret = i2c_smbus_read_word_data(client, TPS23881_REG_FAULT);
> > + if (ret < 0)
> > + return PSE_FAILED_RETRY;
> > +
> > + val = (u16)(ret & 0xf0f);
> > +
> > + /* Power cut detected, shutdown low priority port */
> > + if (val && priv->oss)
> > + tps23881_turn_off_low_prio(priv);
>
> Sorry, this is policy and even not the best one.
> The priority concept is related to the power budget, but this
> implementation will shutdown all low prios ports only if some
> port/channel has over-current event. It means, in case high prio port
> has over-current event, it will be not shut down.
>
> I'll propose not to add prio support for this chip right now, it will
> need more software infrastructure to handle it nearly in similar way as
> it is done by pd692x0.

Yes, I have expected some debate around this support.
I was not sure of the policy while developing it.
Ok, let's remove it for now.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering