Re: [PATCH net-next 08/12] net: pse-pd: pd692x0: Add support for PSE PI priority feature

Kory Maincent
2024-10-03T08:01:45Z

On Thu, 3 Oct 2024 01:41:02 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> > + msg = pd692x0_msg_template_list[PD692X0_MSG_SET_PORT_PARAM];
> > + msg.sub[2] = id;
> > + /* Controller priority from 1 to 3 */
> > + msg.data[4] = prio + 1;
>
> Does 0 have a meaning? It just seems an odd design if it does not.

PD692x0 has an odd firmware design from the beginning. ;)
Yes, the priority available are from 1 to 3. Setting it to 0 does nothing.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering