Re: [PATCH net-next 10/12] net: pse-pd: Register regulator even for undescribed PSE PIs

Kory Maincent
2024-10-03T08:19:46Z

Hello Andrew,

Thanks for your review!

On Thu, 3 Oct 2024 01:46:22 +0200
Andrew Lunn <andrew@lunn.ch> wrote:

> On Wed, Oct 02, 2024 at 06:28:06PM +0200, Kory Maincent wrote:
> > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> >
> > Ensure that regulators are registered for all PSE PIs, even those not
> > explicitly described in the device tree. This change lays the
> > groundwork for future support of regulator notifiers. Maintaining
> > consistent ordering between the PSE PIs regulator table and the
> > regulator notifier table will prevent added complexity in future
> > implementations.
>
> Does this change anything visible to the user?

No it doesn't.

> Is it guaranteed that these unused regulators are disabled? Not that
> they were before i guess. But now they exist, should we disable them?

Indeed we could disable PI not described in the devicetree.

Regards,
--
Köry Maincent, Bootlin
Embedded Linux and kernel engineering