From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f73.google.com (mail-pj1-f73.google.com [209.85.216.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 03F9B1922DD for ; Wed, 9 Oct 2024 13:05:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728479146; cv=none; b=onaqN6Av4J5rL4ItmPb+7+APOldHLI4kcRw0NJw+ua59XFxSoiixkxcwo2gVCuEOf27W09x3ILraQl8zwrWpN5T/6kVpniEzgnHG8VcO8rF6aJw5nXpY8oYKiNK6PR+ZNFiKbV5Txc5WKmTjRgRx2eiVdrj/eZgrc9MH+S20VYI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728479146; c=relaxed/simple; bh=NgO/vc7pC+KSeRyD6TqTvTQ6tVFd67ypnLZUSz0PNwI=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=HQxrQQ9yShMMsWSpyYquLH5nvnbhZyma85zlS3000Dv2KWQIGfLcfQ8VMZZC1sLSrb4JtX6wDM/lIuniLMyo0GyaRpEIWbZprNyDrpEqKXsxWFO1Gkx3nS1ppqP7f93c1OnWhvPrgRU/dJgtU8/eubF2Y1gYIBawll6/mEN4oFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=vyh/xcSW; arc=none smtp.client-ip=209.85.216.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="vyh/xcSW" Received: by mail-pj1-f73.google.com with SMTP id 98e67ed59e1d1-2e291d608feso1249680a91.1 for ; Wed, 09 Oct 2024 06:05:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1728479144; x=1729083944; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=M+ZV/trcDNRdWSOYX2HW3DTnbErvfouDCVlcZiKYTHY=; b=vyh/xcSWLTW+0AV7upkdnods6nwP1IS4YjtrM65ALprnzPmiy3beVwJ15R+xYn+WET DE3DTB9Fz7t2GrWSCVudEV/iREFgIkgI6J5G5Txkdm6JparfVdn3gH1M3UwxZTEoE9u7 HOMV9H5vUgrA/hFgj4vGdKJt5+aWw2KUlycMA3S8JKGft+Uuz7GeNuoWO4ivCpO/gx7n RJEiIOzmQkKyYNRG3NPBNg5tdxxrNHAACJ25Op7eyZmTrhK7PLw1vzblOCRMZWeA0BEx 8M5nYFTVvhlVm1CAdtF9c0rmtpbyER31eFH/Uv01zGQrtxc7q46TcDw30L7EWMQhCVug cZqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728479144; x=1729083944; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=M+ZV/trcDNRdWSOYX2HW3DTnbErvfouDCVlcZiKYTHY=; b=FCnuB308KnBDckgGTqZbIqR9Vnw/3NcNQbife+kS3fdA1+Zgvr4hI9IQeQfxY6R9YA ymo+KqwBytbP0/wxJjuKTJMXAD1Rbb21Ovn/o2mHxn2fjaXjJEZTrLVNH8oaFSNLMCJY D5Kd5lbATUU3LkHVINOvDIyGVnyv54xwZozlb4cEwxehQS4yrFds5eqjc9RczmAiZd47 56Q9CoN2OscRdsszKhR3e+oec8jV7wN3YukrbBTRR7e/nMBQnw3vklgN8dWABKLVcSnf hY66+pggkHTxQO/nsfXn94m3An2MQi/PTTj4sAM7N3iCxOGLRnCYl2KO/NGXoLWHSks/ U1Gw== X-Forwarded-Encrypted: i=1; AJvYcCXyCwB5aRXuaDy0X4zTIEPvO+iP569kZImMKgWjS++Y0bGwWD9Zn+5F0dIftAfLMbCvw9zCq/ZAGXSD6LI=@vger.kernel.org X-Gm-Message-State: AOJu0YxdBqeZWZAyzEcpCvMzMdqO2xwK9SEXcIA9zsVQyBnIBSJ6qYtC XVtK4xWk59vMSBcP7QUGRmSSbzo3XXlVmoHuh3FJlj+ImUJRx+FF/Yu5Ikdch6SnVYMb4JsrpTA N6Q== X-Google-Smtp-Source: AGHT+IGNE2KC1dM0KxpRBNF8b2Z0D674nnv00es7vxsYOwAQzlqghuv/SjG5RmZWL23gCO1GPG5K9PVxbZE= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a17:90a:c20d:b0:2d8:a37d:b762 with SMTP id 98e67ed59e1d1-2e2a250ecfamr2290a91.4.1728479144156; Wed, 09 Oct 2024 06:05:44 -0700 (PDT) Date: Wed, 9 Oct 2024 06:05:42 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20241003230105.226476-1-pbonzini@redhat.com> Message-ID: Subject: Re: [PATCH] KVM: x86/mmu: fix KVM_X86_QUIRK_SLOT_ZAP_ALL for shadow MMU From: Sean Christopherson To: Yan Zhao Cc: Paolo Bonzini , linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="us-ascii" On Wed, Oct 09, 2024, Yan Zhao wrote: > On Fri, Oct 04, 2024 at 09:56:07AM -0700, Sean Christopherson wrote: > > > arch/x86/kvm/mmu/mmu.c | 60 ++++++++++++++++++++++++++++++++---------- > > > 1 file changed, 46 insertions(+), 14 deletions(-) > > > > > > diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c > > > index e081f785fb23..912bad4fa88c 100644 > > > --- a/arch/x86/kvm/mmu/mmu.c > > > +++ b/arch/x86/kvm/mmu/mmu.c > > > @@ -1884,10 +1884,14 @@ static bool sp_has_gptes(struct kvm_mmu_page *sp) > > > if (is_obsolete_sp((_kvm), (_sp))) { \ > > > } else > > > > > > -#define for_each_gfn_valid_sp_with_gptes(_kvm, _sp, _gfn) \ > > > +#define for_each_gfn_valid_sp(_kvm, _sp, _gfn) \ > > > for_each_valid_sp(_kvm, _sp, \ > > > &(_kvm)->arch.mmu_page_hash[kvm_page_table_hashfn(_gfn)]) \ > > > - if ((_sp)->gfn != (_gfn) || !sp_has_gptes(_sp)) {} else > > > + if ((_sp)->gfn != (_gfn)) {} else > > > > I don't think we should provide this iterator, because it won't do what most people > > would it expect it to do. Specifically, the "round gfn for level" adjustment that > > is done for direct SPs means that the exact gfn comparison will not get a match, > > even when a SP does "cover" a gfn, or was even created specifically for a gfn. > Right, zapping of sps with no gptes are not necessary. > When role.direct is true, the sp->gfn can even be a non-slot gfn with the leaf > entries being mmio sptes. So, it should be ok to ignore > "!sp_has_gptes(_sp) && (_sp)->gfn == (_gfn)". > > Tests of "normal VM + nested VM + 3 selftests" passed on the 3 configs > 1) modprobe kvm_intel ept=0, > 2) modprobe kvm tdp_mmu=0 > modprobe kvm_intel ept=1 > 3) modprobe kvm tdp_mmu=1 > modprobe kvm_intel ept=1 > > with quirk disabled + below change > > @@ -7071,7 +7077,7 @@ static void kvm_mmu_zap_memslot_pages_and_flush(struct kvm *kvm, > struct kvm_mmu_page *sp; > gfn_t gfn = slot->base_gfn + i; > > - for_each_gfn_valid_sp(kvm, sp, gfn) > + for_each_gfn_valid_sp_with_gptes(kvm, sp, gfn) > kvm_mmu_prepare_zap_page(kvm, sp, &invalid_list); > > if (need_resched() || rwlock_needbreak(&kvm->mmu_lock)) { Ya, I have a patch that I'll send today.