From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5DB961922FC for ; Wed, 9 Oct 2024 11:51:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728474708; cv=none; b=G4jjkVjo9N90cztGE4u5JHoOxMiuEgjSF+aKY5tjPVsQh03RKAwEuRHx/Gv6yhddANorJxbXYcn9948KCgdYvvy5Ryrgt78HgAyhmD2h+zcfMX1XvWlJi7vadGEAMxSZBXMhd3IJwv4oF2m4dUDKyEnu04P0ug7rdTT6ZQkGdW0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1728474708; c=relaxed/simple; bh=7+eISHNu4uiQ47pDt/DSf8ldSBnlnXKbXyoRYwTIlV4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hvIO3Qd961lcb5jKPadREJlzl+44SSNGpZ96ulEzHVGJ0Maxhw9XvIxJZrqEmOeJAOLDH2W/oChIC0QPRcccxBc9bG57cF4zD05N9odePTy/0l9NUyfT2x7sA+xOXTnXh6roM1Te1xi9cwbf/w3CDMo7Ps1I4AltpgNNa+386k4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=bconrrnh; arc=none smtp.client-ip=209.85.208.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="bconrrnh" Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-5c8af23a4fcso8223436a12.0 for ; Wed, 09 Oct 2024 04:51:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1728474704; x=1729079504; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=bconrrnh5UBET17mgUpmkSN1m5qgRjh8eCY5G/Naz8I2SL39LdYZ5Bf64LNbSaPkld P/10x2VoSwFA4xiPciX/BNBSh5TuiHrTbeGU9DJqf1BhrmYtfRirvtbodKDu+svDloKu O3vhd4hmbPZ4LTx0o7PUe2Y6ikDymaKnW5glnhfpDtOCv6o4OM1mDl6CDGPb1AFbCbYc 8/zYqR4SuYiNr+tNx1UPGhQzI1oxRVxt9lxpyOqYrfRh86AcfAqSFPnGEj3PFlge6byP 2OZu7GY6q0OsjFzYup4QZiFAGx7+zEBR+cUV5YdIk8McceVI6DxE+5c4VSmpTtqGHbcU AH2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728474704; x=1729079504; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q6jKWjRvRRcJdMU7TrSrOqImZ9Mn58A79NvUZszvi6E=; b=SaSC6E9luoKSfrUS2IR61K8dH2GK5pO7/V2PriRQPGCqwJguonPV/XGxAqkwo9QxwE GWfUtBKnVJb7NSTblfrWV13/rIf1Mlb2SX9Dbk36P8IiGa1gww1xQuD7Dl0IVljEDvfI /s/XJ52LYstY7HmbvnIX069Cxkg6yYPvyMHonaY8iytePukb0A5SxoiM/2HUaWNyUT9y foWNz74PJlTiefZNbI7snT38kLmwuyediwVNJoJQppGSOJUl+E6Y8vznenxIrIVRUdSi BRz4CrXeWpOq52LbQC2NdHudnkFh+MEt612I9QXAXCNYPo/S6tAJm8Lk7U4USAbpuyBI ct3w== X-Forwarded-Encrypted: i=1; AJvYcCVTYvnxqw6gxoKd5pFH5OSX4uOK9Yd3EU2DA2fU5yjLXKgXjefJDTwQwh5e+wl0LclU6B3ExMtLnTnTiIQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzr9VBJjXvvWrCFVe6bwGRi6VFDu1T7hvUH8TB7wneoqH86NUVV 0ZpodU1hx820i/2o784hXe9onX3La+jSLAh52d3+y0T2hl1icI7adJdotGAmtno= X-Google-Smtp-Source: AGHT+IGKpe5RJdRvKaNKGeWlJU8yuhUR86qwyFDbVPAhlwFfcx+fGtxwpK017I4wKqBnPOdRSWgB4w== X-Received: by 2002:a17:907:3da7:b0:a99:451b:38fe with SMTP id a640c23a62f3a-a998d174df2mr179992766b.26.1728474703666; Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Received: from linaro.org ([82.77.84.93]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a995668f4b6sm396323966b.48.2024.10.09.04.51.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Oct 2024 04:51:43 -0700 (PDT) Date: Wed, 9 Oct 2024 14:51:41 +0300 From: Abel Vesa To: Pengfei Li Cc: krzk+dt@kernel.org, robh@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-clk@vger.kernel.org, imx@lists.linux.dev, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/2] clk: imx93: Move IMX93_CLK_END macro to clk driver Message-ID: References: <20240627082426.394937-1-pengfei.li_1@nxp.com> <20240627082426.394937-2-pengfei.li_1@nxp.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240627082426.394937-2-pengfei.li_1@nxp.com> On 24-06-27 16:24:25, Pengfei Li wrote: > IMX93_CLK_END was previously defined in imx93-clock.h to indicate > the number of clocks, but it is not part of the ABI, so it should > be moved to clk driver. > > Signed-off-by: Pengfei Li > --- > > Notes: > Change for v2: > - Use pre-processor define to simplify code. > > drivers/clk/imx/clk-imx93.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx93.c b/drivers/clk/imx/clk-imx93.c > index c6a9bc8ecc1f..c8b65146e76e 100644 > --- a/drivers/clk/imx/clk-imx93.c > +++ b/drivers/clk/imx/clk-imx93.c > @@ -15,6 +15,8 @@ > > #include "clk.h" > > +#define IMX93_CLK_END 202 > + TBH, I don't like this. And I still don't understand the reason. Where are the clocks you want to add ? And why wouldn't it be OK to just keep this in the bindings header even if you need to add more clocks ? For the moment, I don't see the value of this change. Sorry, but NACK. > enum clk_sel { > LOW_SPEED_IO_SEL, > NON_IO_SEL, > -- > 2.34.1 >