* [PATCH] lockdep: Use info level for lockdep initial info messages
@ 2024-10-07 6:54 Jiri Slaby (SUSE)
2024-10-07 13:05 ` Waiman Long
2024-10-22 21:53 ` [tip: locking/core] " tip-bot2 for Jiri Slaby (SUSE)
0 siblings, 2 replies; 4+ messages in thread
From: Jiri Slaby (SUSE) @ 2024-10-07 6:54 UTC (permalink / raw)
To: mingo
Cc: linux-kernel, Jiri Slaby (SUSE), Peter Zijlstra, Ingo Molnar,
Will Deacon, Waiman Long, Boqun Feng
All those:
Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
... MAX_LOCKDEP_SUBCLASSES: 8
... MAX_LOCK_DEPTH: 48
... MAX_LOCKDEP_KEYS: 8192
and so on are dumped with the KERN_WARNING level. It is due to missing
KERN_* annotation.
Use pr_info() instead of bare print() to dump the info with the info
level.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
---
kernel/locking/lockdep.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 536bd471557f..ae8750157099 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -6576,17 +6576,17 @@ EXPORT_SYMBOL_GPL(lockdep_unregister_key);
void __init lockdep_init(void)
{
- printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
+ pr_info("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
- printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
- printk("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
- printk("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
- printk("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
- printk("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
- printk("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
- printk("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
+ pr_info("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
+ pr_info("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
+ pr_info("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
+ pr_info("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
+ pr_info("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
+ pr_info("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
+ pr_info("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
- printk(" memory used by lock dependency info: %zu kB\n",
+ pr_info(" memory used by lock dependency info: %zu kB\n",
(sizeof(lock_classes) +
sizeof(lock_classes_in_use) +
sizeof(classhash_table) +
@@ -6604,12 +6604,12 @@ void __init lockdep_init(void)
);
#if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
- printk(" memory used for stack traces: %zu kB\n",
+ pr_info(" memory used for stack traces: %zu kB\n",
(sizeof(stack_trace) + sizeof(stack_trace_hash)) / 1024
);
#endif
- printk(" per task-struct memory footprint: %zu bytes\n",
+ pr_info(" per task-struct memory footprint: %zu bytes\n",
sizeof(((struct task_struct *)NULL)->held_locks));
}
--
2.46.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] lockdep: Use info level for lockdep initial info messages
2024-10-07 6:54 [PATCH] lockdep: Use info level for lockdep initial info messages Jiri Slaby (SUSE)
@ 2024-10-07 13:05 ` Waiman Long
2024-10-09 22:45 ` Boqun Feng
2024-10-22 21:53 ` [tip: locking/core] " tip-bot2 for Jiri Slaby (SUSE)
1 sibling, 1 reply; 4+ messages in thread
From: Waiman Long @ 2024-10-07 13:05 UTC (permalink / raw)
To: Jiri Slaby (SUSE), mingo
Cc: linux-kernel, Peter Zijlstra, Ingo Molnar, Will Deacon,
Boqun Feng
On 10/7/24 2:54 AM, Jiri Slaby (SUSE) wrote:
> All those:
> Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
> ... MAX_LOCKDEP_SUBCLASSES: 8
> ... MAX_LOCK_DEPTH: 48
> ... MAX_LOCKDEP_KEYS: 8192
> and so on are dumped with the KERN_WARNING level. It is due to missing
> KERN_* annotation.
>
> Use pr_info() instead of bare print() to dump the info with the info
> level.
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Waiman Long <longman@redhat.com>
> Cc: Boqun Feng <boqun.feng@gmail.com>
> ---
> kernel/locking/lockdep.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> index 536bd471557f..ae8750157099 100644
> --- a/kernel/locking/lockdep.c
> +++ b/kernel/locking/lockdep.c
> @@ -6576,17 +6576,17 @@ EXPORT_SYMBOL_GPL(lockdep_unregister_key);
>
> void __init lockdep_init(void)
> {
> - printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
> + pr_info("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
>
> - printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
> - printk("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
> - printk("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
> - printk("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
> - printk("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
> - printk("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
> - printk("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
> + pr_info("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
> + pr_info("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
> + pr_info("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
> + pr_info("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
> + pr_info("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
> + pr_info("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
> + pr_info("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
>
> - printk(" memory used by lock dependency info: %zu kB\n",
> + pr_info(" memory used by lock dependency info: %zu kB\n",
> (sizeof(lock_classes) +
> sizeof(lock_classes_in_use) +
> sizeof(classhash_table) +
> @@ -6604,12 +6604,12 @@ void __init lockdep_init(void)
> );
>
> #if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
> - printk(" memory used for stack traces: %zu kB\n",
> + pr_info(" memory used for stack traces: %zu kB\n",
> (sizeof(stack_trace) + sizeof(stack_trace_hash)) / 1024
> );
> #endif
>
> - printk(" per task-struct memory footprint: %zu bytes\n",
> + pr_info(" per task-struct memory footprint: %zu bytes\n",
> sizeof(((struct task_struct *)NULL)->held_locks));
> }
>
Make sense!
Reviewed-by: Waiman Long <longman@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] lockdep: Use info level for lockdep initial info messages
2024-10-07 13:05 ` Waiman Long
@ 2024-10-09 22:45 ` Boqun Feng
0 siblings, 0 replies; 4+ messages in thread
From: Boqun Feng @ 2024-10-09 22:45 UTC (permalink / raw)
To: Waiman Long
Cc: Jiri Slaby (SUSE), mingo, linux-kernel, Peter Zijlstra,
Ingo Molnar, Will Deacon
On Mon, Oct 07, 2024 at 09:05:25AM -0400, Waiman Long wrote:
> On 10/7/24 2:54 AM, Jiri Slaby (SUSE) wrote:
> > All those:
> > Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
> > ... MAX_LOCKDEP_SUBCLASSES: 8
> > ... MAX_LOCK_DEPTH: 48
> > ... MAX_LOCKDEP_KEYS: 8192
> > and so on are dumped with the KERN_WARNING level. It is due to missing
> > KERN_* annotation.
> >
> > Use pr_info() instead of bare print() to dump the info with the info
> > level.
> >
> > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> > Cc: Peter Zijlstra <peterz@infradead.org>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: Waiman Long <longman@redhat.com>
> > Cc: Boqun Feng <boqun.feng@gmail.com>
> > ---
> > kernel/locking/lockdep.c | 22 +++++++++++-----------
> > 1 file changed, 11 insertions(+), 11 deletions(-)
> >
> > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
> > index 536bd471557f..ae8750157099 100644
> > --- a/kernel/locking/lockdep.c
> > +++ b/kernel/locking/lockdep.c
> > @@ -6576,17 +6576,17 @@ EXPORT_SYMBOL_GPL(lockdep_unregister_key);
> > void __init lockdep_init(void)
> > {
> > - printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
> > + pr_info("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
> > - printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
> > - printk("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
> > - printk("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
> > - printk("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
> > - printk("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
> > - printk("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
> > - printk("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
> > + pr_info("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
> > + pr_info("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
> > + pr_info("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
> > + pr_info("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
> > + pr_info("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
> > + pr_info("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
> > + pr_info("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
> > - printk(" memory used by lock dependency info: %zu kB\n",
> > + pr_info(" memory used by lock dependency info: %zu kB\n",
> > (sizeof(lock_classes) +
> > sizeof(lock_classes_in_use) +
> > sizeof(classhash_table) +
> > @@ -6604,12 +6604,12 @@ void __init lockdep_init(void)
> > );
> > #if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
> > - printk(" memory used for stack traces: %zu kB\n",
> > + pr_info(" memory used for stack traces: %zu kB\n",
> > (sizeof(stack_trace) + sizeof(stack_trace_hash)) / 1024
> > );
> > #endif
> > - printk(" per task-struct memory footprint: %zu bytes\n",
> > + pr_info(" per task-struct memory footprint: %zu bytes\n",
> > sizeof(((struct task_struct *)NULL)->held_locks));
> > }
>
> Make sense!
>
> Reviewed-by: Waiman Long <longman@redhat.com>
>
Thanks!
Queued in lockdep tree:
https://git.kernel.org/pub/scm/linux/kernel/git/boqun/linux.git/log/?h=lockdep-for-tip
will send a PR to tip between -rc3 and -rc4.
Regards,
Boqun
^ permalink raw reply [flat|nested] 4+ messages in thread
* [tip: locking/core] lockdep: Use info level for lockdep initial info messages
2024-10-07 6:54 [PATCH] lockdep: Use info level for lockdep initial info messages Jiri Slaby (SUSE)
2024-10-07 13:05 ` Waiman Long
@ 2024-10-22 21:53 ` tip-bot2 for Jiri Slaby (SUSE)
1 sibling, 0 replies; 4+ messages in thread
From: tip-bot2 for Jiri Slaby (SUSE) @ 2024-10-22 21:53 UTC (permalink / raw)
To: linux-tip-commits
Cc: Jiri Slaby (SUSE), Peter Zijlstra, Ingo Molnar, Will Deacon,
Waiman Long, Boqun Feng, x86, linux-kernel
The following commit has been merged into the locking/core branch of tip:
Commit-ID: e48bf7ca6056297664eb260fa88cae8e50d9b698
Gitweb: https://git.kernel.org/tip/e48bf7ca6056297664eb260fa88cae8e50d9b698
Author: Jiri Slaby (SUSE) <jirislaby@kernel.org>
AuthorDate: Mon, 07 Oct 2024 08:54:57 +02:00
Committer: Boqun Feng <boqun.feng@gmail.com>
CommitterDate: Thu, 17 Oct 2024 21:21:16 -07:00
lockdep: Use info level for lockdep initial info messages
All those:
Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar
... MAX_LOCKDEP_SUBCLASSES: 8
... MAX_LOCK_DEPTH: 48
... MAX_LOCKDEP_KEYS: 8192
and so on are dumped with the KERN_WARNING level. It is due to missing
KERN_* annotation.
Use pr_info() instead of bare printk() to dump the info with the info
level.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Will Deacon <will@kernel.org>
Cc: Waiman Long <longman@redhat.com>
Cc: Boqun Feng <boqun.feng@gmail.com>
Reviewed-by: Waiman Long <longman@redhat.com>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Link: https://lore.kernel.org/r/20241007065457.20128-1-jirislaby@kernel.org
---
kernel/locking/lockdep.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c
index 6fd4af2..2d8ec03 100644
--- a/kernel/locking/lockdep.c
+++ b/kernel/locking/lockdep.c
@@ -6600,17 +6600,17 @@ EXPORT_SYMBOL_GPL(lockdep_unregister_key);
void __init lockdep_init(void)
{
- printk("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
+ pr_info("Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar\n");
- printk("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
- printk("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
- printk("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
- printk("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
- printk("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
- printk("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
- printk("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
+ pr_info("... MAX_LOCKDEP_SUBCLASSES: %lu\n", MAX_LOCKDEP_SUBCLASSES);
+ pr_info("... MAX_LOCK_DEPTH: %lu\n", MAX_LOCK_DEPTH);
+ pr_info("... MAX_LOCKDEP_KEYS: %lu\n", MAX_LOCKDEP_KEYS);
+ pr_info("... CLASSHASH_SIZE: %lu\n", CLASSHASH_SIZE);
+ pr_info("... MAX_LOCKDEP_ENTRIES: %lu\n", MAX_LOCKDEP_ENTRIES);
+ pr_info("... MAX_LOCKDEP_CHAINS: %lu\n", MAX_LOCKDEP_CHAINS);
+ pr_info("... CHAINHASH_SIZE: %lu\n", CHAINHASH_SIZE);
- printk(" memory used by lock dependency info: %zu kB\n",
+ pr_info(" memory used by lock dependency info: %zu kB\n",
(sizeof(lock_classes) +
sizeof(lock_classes_in_use) +
sizeof(classhash_table) +
@@ -6628,12 +6628,12 @@ void __init lockdep_init(void)
);
#if defined(CONFIG_TRACE_IRQFLAGS) && defined(CONFIG_PROVE_LOCKING)
- printk(" memory used for stack traces: %zu kB\n",
+ pr_info(" memory used for stack traces: %zu kB\n",
(sizeof(stack_trace) + sizeof(stack_trace_hash)) / 1024
);
#endif
- printk(" per task-struct memory footprint: %zu bytes\n",
+ pr_info(" per task-struct memory footprint: %zu bytes\n",
sizeof(((struct task_struct *)NULL)->held_locks));
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-22 21:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-07 6:54 [PATCH] lockdep: Use info level for lockdep initial info messages Jiri Slaby (SUSE)
2024-10-07 13:05 ` Waiman Long
2024-10-09 22:45 ` Boqun Feng
2024-10-22 21:53 ` [tip: locking/core] " tip-bot2 for Jiri Slaby (SUSE)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox