From: Johan Hovold <johan@kernel.org>
To: cristian.marussi@arm.com
Cc: linux-kernel@vger.kernel.org, arm-scmi@vger.kernel.org,
sudeep.holla@arm.com, cristian.marussi@arm.com,
quic_sibis@quicinc.com, konradybcio@kernel.org,
johan+linaro@kernel.org
Subject: Re: [PATCH] firmware: arm_scmi: Skip opp duplicates
Date: Thu, 10 Oct 2024 16:43:06 +0200 [thread overview]
Message-ID: <Zwfn-kGr1yYP8Xff@hovoldconsulting.com> (raw)
In-Reply-To: <20241009143905.2440438-1-cristian.marussi@arm.com>
[ There appears to be something wrong with you mail setup as the patch
had a bogus Reply-To header:
Reply-To: 20241007060642.1978049-3-quic_sibis@quicinc.com
]
On Wed, Oct 09, 2024 at 03:39:05PM +0100, Cristian Marussi wrote:
> Buggy firmware can reply with duplicated PERF opps descriptors.
>
> Ensure that the bad duplicates reported by the platform firmware doesn't
> get added to the opp-tables.
>
> Reported-by: Johan Hovold <johan+linaro@kernel.org>
> Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@hovoldconsulting.com/
> Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
> ---
> A new version to include in this series that should address the limit case
> described by Sibi...not tested, of course :P
Thanks for the fix. This seems to do the trick and gets rid of the
warnings about duplicate entries on boot and resume (including the
debugfs errors).
Tested-by: Johan Hovold <johan+linaro@kernel.org>
Johan
next prev parent reply other threads:[~2024-10-10 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 14:39 [PATCH] firmware: arm_scmi: Skip opp duplicates Cristian Marussi
2024-10-10 14:43 ` Johan Hovold [this message]
2024-10-10 15:18 ` Cristian Marussi
2024-10-14 10:54 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zwfn-kGr1yYP8Xff@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=cristian.marussi@arm.com \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_sibis@quicinc.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox