From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Icenowy Zheng <uwu@icenowy.me>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] ALSA: emu10k1: add a capability bit for no MIDI
Date: Sun, 13 Oct 2024 11:54:11 +0200 [thread overview]
Message-ID: <ZwuYw27Y1YQy-DQJ@ugly> (raw)
In-Reply-To: <20241013014714.7686-2-uwu@icenowy.me>
On Sun, Oct 13, 2024 at 09:47:12AM +0800, Icenowy Zheng wrote:
>+++ b/sound/pci/emu10k1/emu10k1.c
>@@ -133,7 +133,9 @@ static int snd_card_emu10k1_probe(struct pci_dev *pci,
> if (err < 0)
> return err;
> }
>- if (emu->audigy) {
>+ if (emu->card_capabilities->no_midi) {
>+ dev_info(emu->card->dev, "Card has no ext. MIDI ports.\n");
>
seems like excess verbosity. there are much more important things that
are not reported.
>+ } else if (emu->audigy) {
>
i would eliminate that, and instead populate the card table properly.
that's a bit more code, but it's more uniform, and the resulting binary
is even a tiny bit smaller.
also, i would squash the patches, as i see no point in having them
separate, given their size.
regards
next prev parent reply other threads:[~2024-10-13 9:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-13 1:47 [PATCH 0/2] ALSA: emu10k1: hide MPU-401 ports for Audigy Rx Icenowy Zheng
2024-10-13 1:47 ` [PATCH 1/2] ALSA: emu10k1: add a capability bit for no MIDI Icenowy Zheng
2024-10-13 9:54 ` Oswald Buddenhagen [this message]
2024-10-13 10:04 ` Icenowy Zheng
2024-10-13 1:47 ` [PATCH 2/2] ALSA: emu10k1: hide ext. MIDI ports for Audigy Rx Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwuYw27Y1YQy-DQJ@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=uwu@icenowy.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox