From: Ido Schimmel <idosch@nvidia.com>
To: Menglong Dong <menglong8.dong@gmail.com>
Cc: kuba@kernel.org, aleksander.lobakin@intel.com, horms@kernel.org,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
dsahern@kernel.org, dongml2@chinatelecom.cn, amcohen@nvidia.com,
gnault@redhat.com, bpoirier@nvidia.com, b.galvani@gmail.com,
razor@blackwall.org, petrm@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v7 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit()
Date: Sun, 13 Oct 2024 15:43:02 +0300 [thread overview]
Message-ID: <ZwvAVvGFju94UmxN@shredder.mtl.com> (raw)
In-Reply-To: <20241009022830.83949-9-dongml2@chinatelecom.cn>
On Wed, Oct 09, 2024 at 10:28:26AM +0800, Menglong Dong wrote:
> Replace kfree_skb() with kfree_skb_reason() in vxlan_xmit(). Following
> new skb drop reasons are introduced for vxlan:
>
> /* no remote found for xmit */
> SKB_DROP_REASON_VXLAN_NO_REMOTE
> /* packet without necessary metadata reached a device which is
> * in "external" mode
> */
> SKB_DROP_REASON_TUNNEL_TXINFO
>
> Signed-off-by: Menglong Dong <dongml2@chinatelecom.cn>
> Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
The first reason might be useful for the bridge driver as well when
there are no ports to forward the packet to (because of egress filtering
for example), but we can make it more generic if / when the bridge
driver is annotated.
next prev parent reply other threads:[~2024-10-13 12:43 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-09 2:28 [PATCH net-next v7 00/12] net: vxlan: add skb drop reasons support Menglong Dong
2024-10-09 2:28 ` [PATCH net-next v7 01/12] net: skb: add pskb_network_may_pull_reason() helper Menglong Dong
2024-10-09 2:28 ` [PATCH net-next v7 02/12] net: tunnel: add pskb_inet_may_pull_reason() helper Menglong Dong
2024-10-09 2:28 ` [PATCH net-next v7 03/12] net: tunnel: make skb_vlan_inet_prepare() return drop reasons Menglong Dong
2024-10-09 13:37 ` Simon Horman
2024-10-09 2:28 ` [PATCH net-next v7 04/12] net: vxlan: add skb drop reasons to vxlan_rcv() Menglong Dong
2024-10-13 11:05 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 05/12] net: vxlan: make vxlan_remcsum() return drop reasons Menglong Dong
2024-10-13 11:11 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 06/12] net: vxlan: make vxlan_snoop() " Menglong Dong
2024-10-13 11:40 ` Ido Schimmel
2024-10-14 12:44 ` Menglong Dong
2024-10-09 2:28 ` [PATCH net-next v7 07/12] net: vxlan: make vxlan_set_mac() " Menglong Dong
2024-10-13 12:04 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 08/12] net: vxlan: use kfree_skb_reason() in vxlan_xmit() Menglong Dong
2024-10-13 12:43 ` Ido Schimmel [this message]
2024-10-14 12:35 ` Menglong Dong
2024-10-14 15:47 ` Ido Schimmel
2024-10-15 1:55 ` Menglong Dong
2024-10-09 2:28 ` [PATCH net-next v7 09/12] net: vxlan: add drop reasons support to vxlan_xmit_one() Menglong Dong
2024-10-13 13:17 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 10/12] net: vxlan: use kfree_skb_reason() in vxlan_mdb_xmit() Menglong Dong
2024-10-13 13:18 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 11/12] net: vxlan: use kfree_skb_reason() in vxlan_encap_bypass() Menglong Dong
2024-10-13 13:19 ` Ido Schimmel
2024-10-09 2:28 ` [PATCH net-next v7 12/12] net: vxlan: use kfree_skb_reason() in encap_bypass_if_local() Menglong Dong
2024-10-13 13:24 ` Ido Schimmel
2024-10-14 12:30 ` Menglong Dong
2024-10-15 0:21 ` [PATCH net-next v7 00/12] net: vxlan: add skb drop reasons support Jakub Kicinski
2024-10-15 1:58 ` Menglong Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZwvAVvGFju94UmxN@shredder.mtl.com \
--to=idosch@nvidia.com \
--cc=aleksander.lobakin@intel.com \
--cc=amcohen@nvidia.com \
--cc=b.galvani@gmail.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dongml2@chinatelecom.cn \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=gnault@redhat.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=menglong8.dong@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox