From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C2841CCB54 for ; Mon, 28 Oct 2024 09:50:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730109045; cv=none; b=VzcZBsrHpo6oLmmrpTjLyfnVWDylun+R0ijP8PVIn28ZjOd/mBnhCCHAgIwJf7gfkeB9ghE+3AqRAk8CyJ83D/yzotSFI0yBtnHI87gGC6dDUvILUOXK9vmb4hJd00VmJ+xcDehfxh0cnikB6sWxy8vTDbiH+AQA9N70LiM6H5U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730109045; c=relaxed/simple; bh=p6cWNZM8V5iy2HRy5502SXuAkmNh63oNQa4S/jY+qvE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=XBH1/KGIYTF/k0pbFNu4mKTqsEaZ7kwcqDtR1Jy4vcPX8PCbIYms3m6AUQbiraWygLLdprQ82sEvQyflo9WgP0ngieg3FKY80IqSxrKQhKjWODFCLQY3pXb18qnxXT7rDwCdrjSxMM6dkh6Ux6bMxmnuJweM4i9WYfjhwDOozU8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=PIdfLF6x; arc=none smtp.client-ip=217.70.183.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="PIdfLF6x" Received: by mail.gandi.net (Postfix) with ESMTPSA id B2DCE1BF209; Mon, 28 Oct 2024 09:50:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1730109041; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HMje/jaMOBOoFF5sU1fzBOV+Al4oCoFrkcWCIyXxAMc=; b=PIdfLF6xV2QjEBH9FyJ/Z/waKAEdyYQeDZdYj0CHhgAeh3Fm02NSySlyHgVKlEIllLCEUy 4tYdBuPpBbzSmgNYz7tTV1vRSc3wCGyAlIoOrj9yMMSC9FPI8seDyr+cBnbQxA5nvXNprj 0dxcqprRg2KA2al2amKwyO3Mwgi7l7jzAvkuZg87DXhMXjR2oB0ay+XqhE+be9BsUvdoC1 KV6aQEzH0l6QKZb90OmeHKTcxHt2TiMKbkmE1rxi/ZAVwRX49Ck9C2/QxZNNTJz8W3Kcgb ZSuroVB7kactx9+d5z4U6mP5wDU/LISDZeidM6aSor7LNah7dRlTZMs69JAz+A== Date: Mon, 28 Oct 2024 10:50:39 +0100 From: Louis Chauvet To: =?iso-8859-1?Q?Ma=EDra?= Canal Cc: Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Simona Vetter , dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, 20241007-yuv-v12-0-01c1ada6fec8@bootlin.com Subject: Re: [PATCH RESEND v2 3/8] drm/vkms: Add support for ARGB16161616 formats Message-ID: Mail-Followup-To: =?iso-8859-1?Q?Ma=EDra?= Canal , Rodrigo Siqueira , Melissa Wen , Haneen Mohammed , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Simona Vetter , dri-devel@lists.freedesktop.org, arthurgrillo@riseup.net, linux-kernel@vger.kernel.org, jeremie.dautheribes@bootlin.com, miquel.raynal@bootlin.com, thomas.petazzoni@bootlin.com, seanpaul@google.com, marcheu@google.com, nicolejadeyee@google.com, 20241007-yuv-v12-0-01c1ada6fec8@bootlin.com References: <20241007-b4-new-color-formats-v2-0-d47da50d4674@bootlin.com> <20241007-b4-new-color-formats-v2-3-d47da50d4674@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-GND-Sasl: louis.chauvet@bootlin.com On 26/10/24 - 11:15, Maíra Canal wrote: > Hi Louis, > > On 07/10/24 13:46, Louis Chauvet wrote: > > The formats XRGB16161616 and ARGB16161616 were already supported. > > Add the support for: > > - ABGR16161616 > > - XBGR16161616 > > > > Signed-off-by: Louis Chauvet > > --- > > drivers/gpu/drm/vkms/vkms_formats.c | 11 ++++++++--- > > drivers/gpu/drm/vkms/vkms_plane.c | 2 ++ > > 2 files changed, 10 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/vkms/vkms_formats.c b/drivers/gpu/drm/vkms/vkms_formats.c > > index b5a38f70c62b..c03a481f5005 100644 > > --- a/drivers/gpu/drm/vkms/vkms_formats.c > > +++ b/drivers/gpu/drm/vkms/vkms_formats.c > > @@ -441,9 +441,10 @@ READ_LINE_ARGB8888(ABGR8888_read_line, px, px[3], px[0], px[1], px[2]) > > READ_LINE_ARGB8888(RGBA8888_read_line, px, px[0], px[3], px[2], px[1]) > > READ_LINE_ARGB8888(BGRA8888_read_line, px, px[0], px[1], px[2], px[3]) > > - > > -READ_LINE_16161616(ARGB16161616_read_line, px, px[3], px[2], px[1], px[0]); > > -READ_LINE_16161616(XRGB16161616_read_line, px, 0xFFFF, px[2], px[1], px[0]); > > Please, correct the error in the patch that introduced. Don't fix it in > an unrelated patch. Thanks! > > +READ_LINE_16161616(ARGB16161616_read_line, px, px[3], px[2], px[1], px[0]) > > +READ_LINE_16161616(ABGR16161616_read_line, px, px[3], px[0], px[1], px[2]) > > +READ_LINE_16161616(XRGB16161616_read_line, px, 0xFFFF, px[2], px[1], px[0]) > > Please, be consistent in the use of decimal numbers and hexadecimal > number. If you prefer to use hexadecimal, don't use 255, use 0xFF. I will change everything to hexadecimal for the v2. > > +READ_LINE_16161616(XBGR16161616_read_line, px, 0xFFFF, px[0], px[1], px[2]) > > Are you using tests to check the new formats? I need to check which ones, but I think yes. Thanks, Louis Chauvet > Best Regards, > - Maíra > > > READ_LINE(RGB565_read_line, px, __le16, argb_u16_from_RGB565, px) > > @@ -659,8 +660,12 @@ pixel_read_line_t get_pixel_read_line_function(u32 format) > > return &BGRX8888_read_line; > > case DRM_FORMAT_ARGB16161616: > > return &ARGB16161616_read_line; > > + case DRM_FORMAT_ABGR16161616: > > + return &ABGR16161616_read_line; > > case DRM_FORMAT_XRGB16161616: > > return &XRGB16161616_read_line; > > + case DRM_FORMAT_XBGR16161616: > > + return &XBGR16161616_read_line; > > case DRM_FORMAT_RGB565: > > return &RGB565_read_line; > > case DRM_FORMAT_NV12: > > diff --git a/drivers/gpu/drm/vkms/vkms_plane.c b/drivers/gpu/drm/vkms/vkms_plane.c > > index 941a6e92a040..1e971c7760d9 100644 > > --- a/drivers/gpu/drm/vkms/vkms_plane.c > > +++ b/drivers/gpu/drm/vkms/vkms_plane.c > > @@ -22,7 +22,9 @@ static const u32 vkms_formats[] = { > > DRM_FORMAT_RGBX8888, > > DRM_FORMAT_BGRX8888, > > DRM_FORMAT_XRGB16161616, > > + DRM_FORMAT_XBGR16161616, > > DRM_FORMAT_ARGB16161616, > > + DRM_FORMAT_ABGR16161616, > > DRM_FORMAT_RGB565, > > DRM_FORMAT_NV12, > > DRM_FORMAT_NV16, > >