Re: [PATCH net-next v2 04/18] bpf, xdp: constify some bpf_prog * function arguments

Alexander Lobakin
2024-10-21T13:56:54Z

From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Date: Thu, 17 Oct 2024 13:12:58 +0200

> On Tue, Oct 15, 2024 at 04:53:36PM +0200, Alexander Lobakin wrote:
>> In lots of places, bpf_prog pointer is used only for tracing or other
>> stuff that doesn't modify the structure itself. Same for net_device.
>> Address at least some of them and add `const` attributes there. The
>> object code didn't change, but that may prevent unwanted data
>> modifications and also allow more helpers to have const arguments.
>
> I believe that this patch is not related to idpf XDP support at all. This
> could be pulled out and send separately and reduce the amount of code
> jungle that one has to go through in this set ;)

First of all, this series is called "core code changes".

Second is that without this patch I simply can't introduce libeth_xdp in
its current form, as in some functions I pass const pointers, but here
they won't be const -> compile-time error.

Thanks,
Olek