* [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies
@ 2024-10-15 15:21 Arnd Bergmann
2024-10-17 0:26 ` Sean Christopherson
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2024-10-15 15:21 UTC (permalink / raw)
To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Simona Vetter, Paolo Bonzini
Cc: Arnd Bergmann, Maxime Ripard, Geert Uytterhoeven, Imre Deak,
intel-gfx, dri-devel, linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
Depending on x86 and KVM is not enough, as the kvm helper functions
that get called here are controlled by CONFIG_KVM_X86, which is
disabled if both KVM_INTEL and KVM_AMD are turned off.
ERROR: modpost: "kvm_write_track_remove_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
ERROR: modpost: "kvm_page_track_register_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
ERROR: modpost: "kvm_page_track_unregister_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
ERROR: modpost: "kvm_write_track_add_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
Change the dependency to CONFIG_KVM_X86 instead.
Fixes: ea4290d77bda ("KVM: x86: leave kvm.ko out of the build if no vendor module is requested")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/gpu/drm/i915/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index 46301c06d18a..985cb78d8256 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -118,9 +118,8 @@ config DRM_I915_USERPTR
config DRM_I915_GVT_KVMGT
tristate "Enable KVM host support Intel GVT-g graphics virtualization"
depends on DRM_I915
- depends on X86
+ depends on KVM_X86
depends on 64BIT
- depends on KVM
depends on VFIO
select DRM_I915_GVT
select KVM_EXTERNAL_WRITE_TRACKING
--
2.39.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies
2024-10-15 15:21 [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies Arnd Bergmann
@ 2024-10-17 0:26 ` Sean Christopherson
2024-10-17 5:11 ` Arnd Bergmann
0 siblings, 1 reply; 4+ messages in thread
From: Sean Christopherson @ 2024-10-17 0:26 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
David Airlie, Simona Vetter, Paolo Bonzini, Arnd Bergmann,
Maxime Ripard, Geert Uytterhoeven, Imre Deak, intel-gfx,
dri-devel, linux-kernel
On Tue, Oct 15, 2024, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Depending on x86 and KVM is not enough, as the kvm helper functions
> that get called here are controlled by CONFIG_KVM_X86, which is
> disabled if both KVM_INTEL and KVM_AMD are turned off.
>
> ERROR: modpost: "kvm_write_track_remove_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
> ERROR: modpost: "kvm_page_track_register_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
> ERROR: modpost: "kvm_page_track_unregister_notifier" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
> ERROR: modpost: "kvm_write_track_add_gfn" [drivers/gpu/drm/i915/kvmgt.ko] undefined!
>
> Change the dependency to CONFIG_KVM_X86 instead.
>
> Fixes: ea4290d77bda ("KVM: x86: leave kvm.ko out of the build if no vendor module is requested")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/gpu/drm/i915/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index 46301c06d18a..985cb78d8256 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -118,9 +118,8 @@ config DRM_I915_USERPTR
> config DRM_I915_GVT_KVMGT
> tristate "Enable KVM host support Intel GVT-g graphics virtualization"
> depends on DRM_I915
> - depends on X86
> + depends on KVM_X86
Can GVT-g even work on non-Intel CPUs? I.e. would it make sense to take a
dependency on KVM_INTEL?
> depends on 64BIT
> - depends on KVM
> depends on VFIO
> select DRM_I915_GVT
> select KVM_EXTERNAL_WRITE_TRACKING
> --
> 2.39.5
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies
2024-10-17 0:26 ` Sean Christopherson
@ 2024-10-17 5:11 ` Arnd Bergmann
2024-10-17 16:54 ` Rodrigo Vivi
0 siblings, 1 reply; 4+ messages in thread
From: Arnd Bergmann @ 2024-10-17 5:11 UTC (permalink / raw)
To: Sean Christopherson, Arnd Bergmann
Cc: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, Tvrtko Ursulin,
Dave Airlie, Simona Vetter, Paolo Bonzini, Maxime Ripard,
Geert Uytterhoeven, Imre Deak, intel-gfx, dri-devel, linux-kernel
On Thu, Oct 17, 2024, at 00:26, Sean Christopherson wrote:
> On Tue, Oct 15, 2024, Arnd Bergmann wrote:
>> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
>> index 46301c06d18a..985cb78d8256 100644
>> --- a/drivers/gpu/drm/i915/Kconfig
>> +++ b/drivers/gpu/drm/i915/Kconfig
>> @@ -118,9 +118,8 @@ config DRM_I915_USERPTR
>> config DRM_I915_GVT_KVMGT
>> tristate "Enable KVM host support Intel GVT-g graphics virtualization"
>> depends on DRM_I915
>> - depends on X86
>> + depends on KVM_X86
>
> Can GVT-g even work on non-Intel CPUs? I.e. would it make sense to take a
> dependency on KVM_INTEL?
>
Yes, I think that should work, but I'm not sure if it needs a dependency
on both KVM_INTEL and KVM_X86 in that case, to handle the link-time
dependency in all configurations.
Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies
2024-10-17 5:11 ` Arnd Bergmann
@ 2024-10-17 16:54 ` Rodrigo Vivi
0 siblings, 0 replies; 4+ messages in thread
From: Rodrigo Vivi @ 2024-10-17 16:54 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Sean Christopherson, Arnd Bergmann, Jani Nikula, Joonas Lahtinen,
Tvrtko Ursulin, Dave Airlie, Simona Vetter, Paolo Bonzini,
Maxime Ripard, Geert Uytterhoeven, Imre Deak, intel-gfx,
dri-devel, linux-kernel
On Thu, Oct 17, 2024 at 05:11:37AM +0000, Arnd Bergmann wrote:
> On Thu, Oct 17, 2024, at 00:26, Sean Christopherson wrote:
> > On Tue, Oct 15, 2024, Arnd Bergmann wrote:
> >> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> >> index 46301c06d18a..985cb78d8256 100644
> >> --- a/drivers/gpu/drm/i915/Kconfig
> >> +++ b/drivers/gpu/drm/i915/Kconfig
> >> @@ -118,9 +118,8 @@ config DRM_I915_USERPTR
> >> config DRM_I915_GVT_KVMGT
> >> tristate "Enable KVM host support Intel GVT-g graphics virtualization"
> >> depends on DRM_I915
> >> - depends on X86
> >> + depends on KVM_X86
> >
> > Can GVT-g even work on non-Intel CPUs? I.e. would it make sense to take a
> > dependency on KVM_INTEL?
> >
>
> Yes, I think that should work, but I'm not sure if it needs a dependency
> on both KVM_INTEL and KVM_X86 in that case, to handle the link-time
> dependency in all configurations.
not sure as well, but let's take the safest approach. pushed this patch.
Thanks
>
> Arnd
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-10-17 16:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-15 15:21 [PATCH] i915: fix DRM_I915_GVT_KVMGT dependencies Arnd Bergmann
2024-10-17 0:26 ` Sean Christopherson
2024-10-17 5:11 ` Arnd Bergmann
2024-10-17 16:54 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox