From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16C251EABBB for ; Thu, 17 Oct 2024 16:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729184288; cv=none; b=ocryT4ZzvLlekmP+P1t69C++/CWvQCDopFI5+qZyFMDSyVsY8wCTk2VdgLsAYRMx9wWiXryht/TAdPnz4W1fKG6iP1phf/9hvqfaTS2eSDvivjxlx9LpDpWmVvqc0l3WipcmnBHkzqa+43icqkpQjE4yw2gNM9VhsstUHF1AQxY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729184288; c=relaxed/simple; bh=PrFPdr0NKJQKUfFjYkGfH7X4s8YeIB65gqZrdgLFzgg=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=W0fYUfNrucp7/S0fAcMNru1btLVWJCmOBronfYEL2/VuqM51f5vt9lLIdRQHSW1qmASefWDfFtMV7guayIHwPxVnfcRXTrWvJCWkk4/A1ORs6CFfIkBTx3kJXcJuNbtxn1CagdKswryzK3jPXGw0ZC3y0ATSvv/nBT14m8jJ2LQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=dDS4lzqE; arc=none smtp.client-ip=209.85.219.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--seanjc.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="dDS4lzqE" Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-e2939e25402so1754152276.2 for ; Thu, 17 Oct 2024 09:58:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1729184286; x=1729789086; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=JPTate8nHmfNvm5RLlOrViAXjwxlfzdSZEYjXEbaR7Q=; b=dDS4lzqE+qvGsIXjESIHfbSiHuUkgmRuua1qeCfqtdFdLhGDXK6aDNl7HXYVCKo71/ Y2loqRt/wXqvaCY+Ob7nw15H42rqOrPWGhc0c7d0ZsyEs+iIo6XfEsTE7EzhcYFYF3Ay HPkpv9Wa1q6rFoa9vO6oGaicPXO1xeAorbrVtbeuIRf47JxpLmuDBvvett906w+r4WcL MZdwWfpe/mdlGsbA62xEAD2QsHIxtpGYgH04XltImtK+f6YzI5dQyw84QXWGF7PAv60f qkvEerPsuqSYodb9nmdhUIXH/KXBeT37ztQsfIJhxQTSILU0NgHMA+Vyp7cCx9neBPW4 Ne1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729184286; x=1729789086; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JPTate8nHmfNvm5RLlOrViAXjwxlfzdSZEYjXEbaR7Q=; b=AqodewCPc6AVU68l+NXRyU1o7iY1wHwDK5NS/3rwmq2sAGx+Jg9GZSn+xcJFBBztnN GPx72SshF6aTFya4NGz+RWseP1iF4MWkoe04/8zggZJQVEtnBRNNBuKC/1uMxUigACNY tFosjrTDW4IOkPGNmqErEST0Nro4FUEcQTDOYbZHoLTO8Ul08hIWXszVWesy9yUuV5iP wMCxlrbgjluEtf45KmDJMbhf8hXHizQvfip0Y+IDIY/HhR2p7srIyZDWxIMjCT4VYFCr wFdxoA9c5rxaCA1hsK4WcDtnsa02huG1yCJvBtqu7JdwI2XYxw8/2aGY+7YgendJL3sQ K25A== X-Forwarded-Encrypted: i=1; AJvYcCWCOn7jH46tkwLPuNrUDx6UkYjyThEer1D7r7POHmTiVvlAfQrqMj5bggTxcKQ1QNSu3q4nU+NAwVBTBvU=@vger.kernel.org X-Gm-Message-State: AOJu0YxNVOxPTuST8OkAS0EOIZLF9Ec3vfPNQQG4HTw1c1GBOe3RGoe3 gptZH+hpgEpgRUaMnMyv8jOv001amYBRq9ZI98F+esmARADkHqdXZPWbukodS14BYYtIbCSiucr Enw== X-Google-Smtp-Source: AGHT+IF7B084V115Sr72nxCNj1jAu1r6gImTDt3pvbXTzRx/HxKwq71Gvz4aJ0aVLn+pxpF6UyiW5mTVJRo= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:9d:3983:ac13:c240]) (user=seanjc job=sendgmr) by 2002:a25:9bc9:0:b0:e2b:a511:2e51 with SMTP id 3f1490d57ef6-e2ba5112f27mr2946276.11.1729184285606; Thu, 17 Oct 2024 09:58:05 -0700 (PDT) Date: Thu, 17 Oct 2024 09:58:03 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20240927161657.68110-1-iorlov@amazon.com> <20240927161657.68110-4-iorlov@amazon.com> Message-ID: Subject: Re: [PATCH 3/3] selftests: KVM: Add test case for MMIO during event delivery From: Sean Christopherson To: David Woodhouse Cc: Ivan Orlov , bp@alien8.de, dave.hansen@linux.intel.com, mingo@redhat.com, pbonzini@redhat.com, shuah@kernel.org, tglx@linutronix.de, hpa@zytor.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, x86@kernel.org, jalliste@amazon.com, nh-open-source@amazon.com, pdurrant@amazon.co.uk Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Thu, Oct 17, 2024, David Woodhouse wrote: > On Fri, 2024-10-11 at 17:21 -0700, Sean Christopherson wrote: > >=20 > > > + > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0/* We should never reach t= his point */ > >=20 > > No pronouns.=C2=A0 Yes, it's nitpicky, but "we" gets _very_ ambiguous w= hen "we" could > > mean the admin, the user, the VMM, KVM, the guest, etc. > >=20 > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0GUEST_ASSERT(0); >=20 >=20 > Is there really *any* way that can be interpreted as anything other > than "the CPU executing this code will never get to this point and > that's why there's an ASSERT(0) right after this comment"? >=20 > I don't believe there's *any* way that particular pronoun can be > ambiguous, and now we've got to the point of fetishising the bizarre > "no pronouns" rule just for the sake of it. No, it's not just for the sake of it. In this case, "we" isn't all that am= biguous, (though my interpretation of it is "the test", not "the CPU"), but only bec= ause the comment is utterly useless. The GUEST_ASSERT(0) communicates very clearly = that it's supposed to be unreachable. And if the comment were rewritten to explain _why_ the code is unreachable,= then "we" is all bug guaranateed to become ambiguous, because explaining "why" l= ikely means preciesly describing the behavior the userspace side, the guest side,= and/or KVM. In other words, using "we" or "us" is often a hint that either the st= atement is likely ambiguous or doesn't add value. And irrespective of whether or not you agree with the above, having a hard = rule of "no we, no us" eliminates all subjectivity, and for me that is sufficient r= eason to enforce the rule. > I get it, especially for some individuals it *can* be difficult to take > context into account, and the wilful use of pronouns instead of > spelling things out explicitly *every* *single* *time* can sometimes > help. But at a cost of conciseness and brevity. In this particular case, I am more than willing to sacrifice brevity. I 10= 0% agree that there is value in having to-the-point comments and changelogs, b= ut I can't recall a single time where avoiding a "we" or "us" made a statement meaningfully harder to read and understand. On ther hand, I can recall man= y, many changelogs I had to re-read multiple times because I struggled to figure ou= t how the author _intended_ "we" or "us" to be interpreted.