From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yoshihiro Furudera <fj5100bi@fujitsu.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA
Date: Fri, 18 Oct 2024 15:41:51 +0300 [thread overview]
Message-ID: <ZxJXj3holsMIdnC2@smile.fi.intel.com> (raw)
In-Reply-To: <20241018015826.2925075-1-fj5100bi@fujitsu.com>
On Fri, Oct 18, 2024 at 01:58:26AM +0000, Yoshihiro Furudera wrote:
> This patch enables DWAPB I2C controller support on Fujitsu MONAKA.
s/This patch enables/Enable/
Also please give more details:
1) is this ID already present in the wild
(in the products that one may just go and buy)?
if so, mention the example of the product.
2) provide an excerpt from DSDT for the Device object that uses this _HID.
Otherwise the vendor ID is legit [1] and code wise patch is okay.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
[1]: https://uefi.org/ACPI_ID_List?acpi_search=fuji
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-18 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 1:58 [PATCH] i2c: designware: Add ACPI HID for DWAPB I2C controller on Fujitsu MONAKA Yoshihiro Furudera
2024-10-18 12:41 ` Andy Shevchenko [this message]
2024-10-21 7:22 ` Yoshihiro Furudera (Fujitsu)
2024-10-21 8:25 ` 'Andy Shevchenko'
2024-10-22 1:14 ` Yoshihiro Furudera (Fujitsu)
2024-10-22 13:12 ` 'Andy Shevchenko'
2024-10-23 4:40 ` Yoshihiro Furudera (Fujitsu)
2024-10-23 14:31 ` 'Andy Shevchenko'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxJXj3holsMIdnC2@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=fj5100bi@fujitsu.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox