From: Niklas Cassel <cassel@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Kishon Vijay Abraham I" <kishon@kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org,
imx@lists.linux.dev, dlemoal@kernel.org, maz@kernel.org,
tglx@linutronix.de, jdmason@kudzu.us
Subject: Re: [PATCH v3 4/6] PCI: endpoint: pci-epf-test: Add doorbell test support
Date: Fri, 18 Oct 2024 16:05:43 +0200 [thread overview]
Message-ID: <ZxJrNwxEvXHx7QCn@ryzen.lan> (raw)
In-Reply-To: <ZxJqITunljv0PGxn@ryzen.lan>
On Fri, Oct 18, 2024 at 04:01:05PM +0200, Niklas Cassel wrote:
> @@ -741,6 +756,32 @@ static void pci_epf_test_clear_bar(struct pci_epf *epf)
> }
> }
>
> +static void pci_epf_test_init_caps(struct pci_epf *epf)
> +{
> + struct pci_epf_test *epf_test = epf_get_drvdata(epf);
> + const struct pci_epc_features *epc_features = epf_test->epc_features;
> + enum pci_barno test_reg_bar = epf_test->test_reg_bar;
> + struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar];
> + u32 caps = 0;
> +
> + reg->caps_magic = cpu_to_le32(CAPS_MAGIC);
> + reg->caps_version = cpu_to_le32(CAPS_VERSION);
> +
> + if (epc_features->msi_capable)
> + caps |= CAPS_MSI_SUPPORT;
> +
> + if (epc_features->msix_capable)
> + caps |= CAPS_MSIX_SUPPORT;
> +
> + if (epf_test->dma_supported)
> + caps |= CAPS_DMA_SUPPORT;
> +
> + if (epf_test->dma_private)
> + caps |= CAPS_DMA_IS_PRIVATE;
> +
> + reg->caps = cpu_to_le64(caps);
opps, this should have been cpu_to_le32(caps);
Kind regards,
Niklas
next prev parent reply other threads:[~2024-10-18 14:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 22:07 [PATCH v3 0/6] PCI: EP: Add RC-to-EP doorbell with platform MSI controller Frank Li
2024-10-15 22:07 ` [PATCH v3 1/6] genirq/msi: Add cleanup guard define for msi_lock_descs()/msi_unlock_descs() Frank Li
2024-10-16 1:12 ` Damien Le Moal
2024-10-16 16:21 ` Thomas Gleixner
2024-10-16 16:33 ` Frank Li
2024-10-15 22:07 ` [PATCH v3 2/6] PCI: endpoint: Add pci_epc_get_fn() API for customizable filtering Frank Li
2024-10-15 22:07 ` [PATCH v3 3/6] PCI: endpoint: Add RC-to-EP doorbell support using platform MSI controller Frank Li
2024-10-16 1:36 ` Damien Le Moal
2024-10-16 15:03 ` Frank Li
2024-10-16 16:30 ` Thomas Gleixner
2024-10-16 16:54 ` Frank Li
2024-10-16 17:35 ` Thomas Gleixner
2024-10-15 22:07 ` [PATCH v3 4/6] PCI: endpoint: pci-epf-test: Add doorbell test support Frank Li
2024-10-18 14:01 ` Niklas Cassel
2024-10-18 14:05 ` Niklas Cassel [this message]
2024-10-18 15:13 ` Frank Li
2024-10-20 14:41 ` Niklas Cassel
2024-10-21 6:55 ` Niklas Cassel
2024-10-21 16:17 ` Frank Li
2024-10-15 22:07 ` [PATCH v3 5/6] misc: pci_endpoint_test: Add doorbell test case Frank Li
2024-10-15 22:07 ` [PATCH v3 6/6] tools: PCI: Add 'B' option for test doorbell Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxJrNwxEvXHx7QCn@ryzen.lan \
--to=cassel@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=dlemoal@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jdmason@kudzu.us \
--cc=kishon@kernel.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox