From: Frederic Weisbecker <frederic@kernel.org>
To: "Paul E. McKenney" <paulmck@kernel.org>
Cc: Michal Schmidt <mschmidt@redhat.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
"Uladzislau Rezki (Sony)" <urezki@gmail.com>,
rcu@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rcu/srcutiny: don't return before reenabling preemption
Date: Fri, 18 Oct 2024 23:10:18 +0200 [thread overview]
Message-ID: <ZxLOut9zT_pfBWAO@pavilion.home> (raw)
In-Reply-To: <6c9dde7f-271b-4342-8ce9-8f363b341c0d@paulmck-laptop>
Le Wed, Oct 09, 2024 at 10:19:01AM -0700, Paul E. McKenney a écrit :
> On Mon, Oct 07, 2024 at 12:14:15PM +0200, Michal Schmidt wrote:
> > Code after the return statement is dead. Enable preemption before
> > returning from srcu_drive_gp().
> >
> > This will be important when/if PREEMPT_AUTO (lazy resched) gets merged.
> >
> > Fixes: 65b4a59557f6 ("srcu: Make Tiny SRCU explicitly disable preemption")
> > Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
>
> Good catch!
>
> Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Applied!
Thanks.
prev parent reply other threads:[~2024-10-18 21:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 10:14 [PATCH] rcu/srcutiny: don't return before reenabling preemption Michal Schmidt
2024-10-09 17:19 ` Paul E. McKenney
2024-10-18 21:10 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxLOut9zT_pfBWAO@pavilion.home \
--to=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mschmidt@redhat.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=urezki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox