Re: [PATCH v1 1/1] Input: xpad - add support for MSI Claw A1M

Christopher Snowhill
2024-10-11T11:28:57Z

On Thu Oct 10, 2024 at 4:09 PM PDT, John Edwards wrote:
> Add MSI Claw A1M controller to xpad_device match table when in xinput mode.
> Add MSI VID as XPAD_XBOX360_VENDOR.
>
> Signed-off-by: John Edwards <uejji@uejji.net>
> Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com>

As a once contributor to the Xbox360 wireless driver, who also happened
to botch the SoB address and missed a CC from GKH later...

Reviewed-by: Christopher Snowhill <kode54@gmail.com>

Also, feel free to be the first to submit a hw-probe of the machine,
since there's no MSI Claw reporting at this time. Guess not many people
would be interested in running Linux on a machine that didn't yet have
working controller support. Thanks for that. :D

> ---
> drivers/input/joystick/xpad.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 4eda18f4f..9f44669df 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -218,6 +218,7 @@ static const struct xpad_device {
> { 0x0c12, 0x8810, "Zeroplus Xbox Controller", 0, XTYPE_XBOX },
> { 0x0c12, 0x9902, "HAMA VibraX - *FAULTY HARDWARE*", 0, XTYPE_XBOX },
> { 0x0d2f, 0x0002, "Andamiro Pump It Up pad", MAP_DPAD_TO_BUTTONS, XTYPE_XBOX },
> + { 0x0db0, 0x1901, "Micro Star International Xbox360 Controller for Windows", 0, XTYPE_XBOX360 },
> { 0x0e4c, 0x1097, "Radica Gamester Controller", 0, XTYPE_XBOX },
> { 0x0e4c, 0x1103, "Radica Gamester Reflex", MAP_TRIGGERS_TO_BUTTONS, XTYPE_XBOX },
> { 0x0e4c, 0x2390, "Radica Games Jtech Controller", 0, XTYPE_XBOX },
> @@ -492,6 +493,7 @@ static const struct usb_device_id xpad_table[] = {
> XPAD_XBOX360_VENDOR(0x07ff), /* Mad Catz Gamepad */
> XPAD_XBOXONE_VENDOR(0x0b05), /* ASUS controllers */
> XPAD_XBOX360_VENDOR(0x0c12), /* Zeroplus X-Box 360 controllers */
> + XPAD_XBOX360_VENDOR(0x0db0), /* Micro Star International X-Box 360 controllers */
> XPAD_XBOX360_VENDOR(0x0e6f), /* 0x0e6f Xbox 360 controllers */
> XPAD_XBOXONE_VENDOR(0x0e6f), /* 0x0e6f Xbox One controllers */
> XPAD_XBOX360_VENDOR(0x0f0d), /* Hori controllers */