From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE0B6199FBF for ; Sat, 19 Oct 2024 01:24:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729301074; cv=none; b=ClZsxuqWXVaIRgy0I+NagXvhk5TMuMPqPdAMq3u1LU3/OjGMdQJ0dHecZ066wYWL8aNTUZvIFu9fUNssi+qwb1SWaXtfVl6Ps0gT/pxlVgXhuE2fu25ofq/MpNwcB5XJd8BcwTzVTwSRz7zH8r46TAqlwBScX05YA9sunHhU1VY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729301074; c=relaxed/simple; bh=coGEllaJzw4cXYWmDPrkgvRbhOBKpa+Twkh3y5h95A0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=uIRvxTPv6t+6985MauVcFpV5oqXrAkRALWlRHKMKUtelWB+0HCjRO+jAbAmEfUNXSD5uzzJ9cgsfWpPYKkKFeImrqtSIXbeZg8MlHfB9VAS3utqeVgmRb/pOMzBzFDmlbZrhfW7G33o52Q03Eh5Vn/xBmoKCAP7Ym26XX0GKwvE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com; spf=pass smtp.mailfrom=rivosinc.com; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b=ts/CdBRA; arc=none smtp.client-ip=209.85.216.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rivosinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.b="ts/CdBRA" Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2e2dcf4b153so2097539a91.1 for ; Fri, 18 Oct 2024 18:24:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1729301072; x=1729905872; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=u9kwzs1TdtVADUdfMGhdcgPMuWpR4rjjZoB45wsX/po=; b=ts/CdBRAU3IEq3sPwNs73V7yDY/IbUOdLdt1sGlqrJOCasFWL+uz59Co9wAGjShrkA GhsUHMGrP8Hz7FbuirIzSJ14nEFZ7RHF2p+R3IWgWoCUy9aQ/JR6KK2MQF/nNngFhb12 jOmbSJBNM42iHsoIiBm4MpmxC+xN4c4BN1pdMqYmnJ53FyRCXe37/mihlmLlrQ1qLDA3 ToTAfOGk2qs5fSyrf1FvfdefRVPPViG0Zj/BVuqs0jt0oPsvtuSgGKE+GaOg2gpQXeAl AjBazHj9K72/U9Lh3rjr0YDHdGN8J3GrNn5nTlH1d8ZnrgF5Gi4OnJ5QOLP6fuwSMbMj g8TA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729301072; x=1729905872; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=u9kwzs1TdtVADUdfMGhdcgPMuWpR4rjjZoB45wsX/po=; b=asKxkne+86Wnv7wUFlyEkeDr/Ubx3isIVDk7dSqCRygtikc/6rMBssBQflHuo8O1v4 bReoDXl6Xry2ilnxYqe67NE+WmkaNV/+wRaxaRJ1BT+M+IfsZ5xLR9e9C1pCFcAL0hzC rWey8wapUeH9OFqTtl6ck++nbtApEdejCHa37TvsDTe9fwoX2J0l138z0L2XP3kiRu7l ZvmJ5QT5Y8taIBRqzCt5A6iXBLEzsshGooiuUeSlYXOTD4cNBlpLlfxztycazaOp7ybN Z0rTr/nFBdg38gHXwonC3wBuBd/bL2UJFbA7nqwjTnGZ69yM6FueFGZrQO1Jacg5OKyg xZNw== X-Forwarded-Encrypted: i=1; AJvYcCVQCucF5yEmNLGTJxEcai0BTudXja8LQ8lEKO20+ggnkdZaqvwBQtBu/Am4u5BIr4OHKHAvL+ygM+CGeP8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9rbaeaTWaJa5knDWNpzYJJirLBho4GD232uLbw47fIP0J4/eK y9DrteGK8FgOvYfMeiT3bMPQSEdA60t3joPs2b3G8aUmIhxKy78VqzHUksQyn50= X-Google-Smtp-Source: AGHT+IF5gcz420u+38TzPNJB0kfsdtlqejiS2yRDhUESPcDHjj1maJyg98yMDT7zKslsLy/qQogdfQ== X-Received: by 2002:a17:90a:ab0e:b0:2e0:74c9:ecf1 with SMTP id 98e67ed59e1d1-2e561718d7amr1522614a91.10.1729301071944; Fri, 18 Oct 2024 18:24:31 -0700 (PDT) Received: from debug.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2e55da7b34fsm2876468a91.54.2024.10.18.18.24.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Oct 2024 18:24:31 -0700 (PDT) Date: Fri, 18 Oct 2024 18:24:29 -0700 From: Deepak Gupta To: Mark Brown Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Arnd Bergmann , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Rick Edgecombe Subject: Re: [PATCH RFC/RFT v2 1/2] mm: helper `is_shadow_stack_vma` to check shadow stack vma Message-ID: References: <20241016-shstk_converge-v2-0-c41536eb5c3b@rivosinc.com> <20241016-shstk_converge-v2-1-c41536eb5c3b@rivosinc.com> <2b24849e-3595-414a-b11e-eb03cd3c3b28@sirena.org.uk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2b24849e-3595-414a-b11e-eb03cd3c3b28@sirena.org.uk> On Thu, Oct 17, 2024 at 12:22:02PM +0100, Mark Brown wrote: >On Wed, Oct 16, 2024 at 02:57:33PM -0700, Deepak Gupta wrote: >> VM_SHADOW_STACK (alias to VM_HIGH_ARCH_5) is used to encode shadow stack >> VMA on three architectures (x86 shadow stack, arm GCS and RISC-V shadow >> stack). In case architecture doesn't implement shadow stack, it's VM_NONE >> Introducing a helper `is_shadow_stack_vma` to determine shadow stack vma >> or not. > >Reviewed-by: Mark Brown > >though > >> @@ -387,7 +392,6 @@ static inline bool is_data_mapping(vm_flags_t flags) >> return (flags & (VM_WRITE | VM_SHARED | VM_STACK)) == VM_WRITE; >> } >> >> - >> static inline void vma_iter_config(struct vma_iterator *vmi, >> unsigned long index, unsigned long last) >> { >> > >Unrelated (but reasonable) whitespace change. Yeah I'll put that in commit message indicating this clean up in next version.