public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo2@yeah.net>
To: Andreas Kemnade <andreas@kemnade.info>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	shawnguo@kernel.org, s.hauer@pengutronix.de,
	kernel@pengutronix.de, festevam@gmail.com,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings
Date: Tue, 22 Oct 2024 11:34:58 +0800	[thread overview]
Message-ID: <ZxcdYudAHVSykFoW@dragon> (raw)
In-Reply-To: <20241021183244.303329-1-andreas@kemnade.info>

On Mon, Oct 21, 2024 at 08:32:44PM +0200, Andreas Kemnade wrote:
> Fix anatop thermal related dtbs_check warnings about node name

Can we be clear what the warning about the node name is, too long?

Shawn

> and missing thermal-cells property.
> 
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6sll.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> index ddeb5b37fb78b..85fe2a4ab97a0 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6sll.dtsi
> @@ -525,7 +525,7 @@ reg_3p0: regulator-3p0@20c8120 {
>  					anatop-enable-bit = <0>;
>  				};
>  
> -				tempmon: temperature-sensor {
> +				tempmon: tempmon {
>  					compatible = "fsl,imx6sll-tempmon", "fsl,imx6sx-tempmon";
>  					interrupts = <GIC_SPI 49 IRQ_TYPE_LEVEL_HIGH>;
>  					interrupt-parent = <&gpc>;
> @@ -533,6 +533,7 @@ tempmon: temperature-sensor {
>  					nvmem-cells = <&tempmon_calib>, <&tempmon_temp_grade>;
>  					nvmem-cell-names = "calib", "temp_grade";
>  					clocks = <&clks IMX6SLL_CLK_PLL3_USB_OTG>;
> +					#thermal-sensor-cells = <0>;
>  				};
>  			};
>  
> -- 
> 2.39.5
> 


  reply	other threads:[~2024-10-22  3:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-21 18:32 [PATCH] ARM: dts: imx6sll: fix anatop thermal dtbs_check warnings Andreas Kemnade
2024-10-22  3:34 ` Shawn Guo [this message]
2024-10-22  6:46   ` Andreas Kemnade
2024-10-22  7:08 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZxcdYudAHVSykFoW@dragon \
    --to=shawnguo2@yeah.net \
    --cc=andreas@kemnade.info \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox