From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Zeng Heng <zengheng4@huawei.com>
Cc: raymondhackley@protonmail.com, markuss.broks@gmail.com,
linux-input@vger.kernel.org, bobo.shaobowang@huawei.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input/touchscreen: imagis: Fix not used variable 'imagis_3038_data'
Date: Wed, 23 Oct 2024 14:22:50 -0700 [thread overview]
Message-ID: <ZxlpKmrYy8srtckn@google.com> (raw)
In-Reply-To: <20241023094831.1680214-1-zengheng4@huawei.com>
On Wed, Oct 23, 2024 at 05:48:31PM +0800, Zeng Heng wrote:
> Fix the following compilation warnings:
> drivers/input/touchscreen/imagis.c:422:39: warning: ‘imagis_3038c_data’
> defined but not used [-Wunused-const-variable=]
> 422 | static const struct imagis_properties imagis_3038c_data = {
> drivers/input/touchscreen/imagis.c:415:39: warning: ‘imagis_3038b_data’
> defined but not used [-Wunused-const-variable=]
> 415 | static const struct imagis_properties imagis_3038b_data = {
> drivers/input/touchscreen/imagis.c:407:39: warning: ‘imagis_3038_data’
> defined but not used [-Wunused-const-variable=]
> 407 | static const struct imagis_properties imagis_3038_data = {
> drivers/input/touchscreen/imagis.c:398:39: warning: ‘imagis_3032c_data’
> defined but not used [-Wunused-const-variable=]
> 398 | static const struct imagis_properties imagis_3032c_data = {
>
> Only define the variables 'imagis_303*_data' when the CONFIG_OF
> is enabled.
>
> Fixes: 1e48ee99f603 ("Input: imagis - add supports for Imagis IST3038")
> Signed-off-by: Zeng Heng <zengheng4@huawei.com>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2024-10-23 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 9:48 [PATCH] input/touchscreen: imagis: Fix not used variable 'imagis_3038_data' Zeng Heng
2024-10-23 13:28 ` Markuss Broks
2024-10-23 21:22 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZxlpKmrYy8srtckn@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=bobo.shaobowang@huawei.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markuss.broks@gmail.com \
--cc=raymondhackley@protonmail.com \
--cc=zengheng4@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).