From: Andy Shevchenko <andy@kernel.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Lee Jones <lee@kernel.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client
Date: Fri, 25 Oct 2024 16:27:48 +0300 [thread overview]
Message-ID: <Zxuc1HWTIiUJ3Rwo@smile.fi.intel.com> (raw)
In-Reply-To: <20241025083712.15070-1-hdegoede@redhat.com>
On Fri, Oct 25, 2024 at 10:37:12AM +0200, Hans de Goede wrote:
> On some x86 Bay Trail tablets which shipped with Android as factory OS,
> the DSDT is so broken that the PMIC needs to be manually instantiated by
> the special x86-android-tablets.ko "fixup" driver for cases like this.
>
> Add an i2c_device_id table so that the driver can match on manually
> instantiated i2c_client-s (which lack an ACPI fwnode to match on).
...
> +static const struct i2c_device_id crystal_cove_i2c_match[] = {
> + { "intel-crystal-cove" },
Why this can't be "crystal_cove_i2c"?
> + { }
> +};
...
> .driver = {
> .name = "crystal_cove_i2c",
> .pm = pm_sleep_ptr(&crystal_cove_pm_ops),
> .acpi_match_table = crystal_cove_acpi_match,
> },
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-10-25 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-25 8:37 [PATCH] mfd: intel_soc_pmic_crc: Add support for non ACPI instantiated i2c_client Hans de Goede
2024-10-25 13:27 ` Andy Shevchenko [this message]
2024-10-26 11:42 ` Hans de Goede
2024-10-28 9:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zxuc1HWTIiUJ3Rwo@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=hdegoede@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox