From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, Nathan Chancellor <nathan@kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Dave Hansen <dave.hansen@intel.com>
Subject: Re: [PATCH v3 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used
Date: Fri, 8 Nov 2024 14:48:07 +0200 [thread overview]
Message-ID: <Zy4Ih3rW7eiyFAsJ@smile.fi.intel.com> (raw)
In-Reply-To: <52362D81-CE7E-4F06-AA1E-B8C55933B4B4@zytor.com>
On Fri, Nov 08, 2024 at 12:50:49PM +0100, H. Peter Anvin wrote:
> On November 8, 2024 10:29:02 AM GMT+01:00, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >On Tue, Sep 10, 2024 at 11:42:42AM +0300, Andy Shevchenko wrote:
> >> When flag_is_changeable_p() is unused, it prevents kernel builds
> >> with clang, `make W=1` and CONFIG_WERROR=y:
> >>
> >> arch/x86/kernel/cpu/common.c:351:19: error: unused function 'flag_is_changeable_p' [-Werror,-Wunused-function]
> >> 351 | static inline int flag_is_changeable_p(u32 flag)
> >> | ^~~~~~~~~~~~~~~~~~~~
> >>
> >> Fix this by moving core around to make sure flag_is_changeable_p() is
> >> always being used.
> >>
> >> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static
> >> inline functions for W=1 build").
> >
> >Any comments on this? Can it be applied?
>
> Incidentally, this really should be "unsigned long" rather than u32, although
> I believe it is only used on 32 bits.
I can fix this in v4, does it warrant your Rb / Ack?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2024-11-08 12:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 8:42 [PATCH v3 1/1] x86/cpu: Make sure flag_is_changeable_p() is always being used Andy Shevchenko
2024-11-08 9:29 ` Andy Shevchenko
2024-11-08 11:50 ` H. Peter Anvin
2024-11-08 12:48 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zy4Ih3rW7eiyFAsJ@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox